Skip to content

Conversation

@eps1lon
Copy link
Collaborator

@eps1lon eps1lon commented Feb 3, 2026

No more seemingly unused import * as React in our Flight fixture. Our version of @babel/plugin-transform-react-jsx requires an explicit runtime: 'automatic' option to use the new runtime for the prod version.

I didn't convert all import * as React to keep the git-blame tidy.

@meta-cla meta-cla bot added the CLA Signed label Feb 3, 2026
@github-actions github-actions bot added the React Core Team Opened by a member of the React Core Team label Feb 3, 2026
require.resolve('babel-preset-react-app'),
{
runtime: hasJsxRuntime ? 'automatic' : 'classic',
runtime: 'automatic',
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change isn't needed. Just made it for consistency to avoid regressions.

@react-sizebot
Copy link

Comparing: d4a325d...542662b

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.js = 6.84 kB 6.84 kB +0.11% 1.88 kB 1.88 kB
oss-stable/react-dom/cjs/react-dom-client.production.js = 609.91 kB 609.91 kB = 107.85 kB 107.85 kB
oss-experimental/react-dom/cjs/react-dom.production.js = 6.84 kB 6.84 kB +0.11% 1.88 kB 1.88 kB
oss-experimental/react-dom/cjs/react-dom-client.production.js = 675.84 kB 675.84 kB = 118.81 kB 118.81 kB
facebook-www/ReactDOM-prod.classic.js = 695.47 kB 695.47 kB = 122.24 kB 122.24 kB
facebook-www/ReactDOM-prod.modern.js = 685.85 kB 685.85 kB = 120.63 kB 120.63 kB

Significant size changes

Includes any change greater than 0.2%:

(No significant changes)

Generated by 🚫 dangerJS against 542662b

@eps1lon eps1lon marked this pull request as ready for review February 3, 2026 08:01
@eps1lon eps1lon merged commit 748ee74 into facebook:main Feb 3, 2026
243 checks passed
@eps1lon eps1lon deleted the sebbie/02-03-use_modern_jsx_runtime_in_flight_fixture branch February 3, 2026 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed React Core Team Opened by a member of the React Core Team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants