Skip to content

[flags] Cleanup enableHalt#35708

Merged
eps1lon merged 4 commits intofacebook:mainfrom
eps1lon:sebbie/02-05-_flags_cleanup_enablehalt_
Feb 6, 2026
Merged

[flags] Cleanup enableHalt#35708
eps1lon merged 4 commits intofacebook:mainfrom
eps1lon:sebbie/02-05-_flags_cleanup_enablehalt_

Conversation

@eps1lon
Copy link
Collaborator

@eps1lon eps1lon commented Feb 5, 2026

This has shipped in 19.2

@meta-cla meta-cla bot added the CLA Signed label Feb 5, 2026
@github-actions github-actions bot added the React Core Team Opened by a member of the React Core Team label Feb 5, 2026
@react-sizebot
Copy link

react-sizebot commented Feb 5, 2026

Comparing: b932350...1c02f8c

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.js = 6.84 kB 6.84 kB = 1.88 kB 1.88 kB
oss-stable/react-dom/cjs/react-dom-client.production.js = 610.53 kB 610.53 kB = 107.91 kB 107.91 kB
oss-experimental/react-dom/cjs/react-dom.production.js = 6.84 kB 6.84 kB = 1.88 kB 1.88 kB
oss-experimental/react-dom/cjs/react-dom-client.production.js = 676.46 kB 676.46 kB = 118.87 kB 118.87 kB
facebook-www/ReactDOM-prod.classic.js = 696.77 kB 696.77 kB = 122.49 kB 122.49 kB
facebook-www/ReactDOM-prod.modern.js = 687.15 kB 687.15 kB = 120.89 kB 120.89 kB

Significant size changes

Includes any change greater than 0.2%:

(No significant changes)

Generated by 🚫 dangerJS against 1c02f8c

Comment on lines -3026 to -3027
// This could be a bug. Discovered while making enableAsyncDebugInfo dynamic for www.
// @gate enableHalt || (enableAsyncDebugInfo && __DEV__)
Copy link
Collaborator Author

@eps1lon eps1lon Feb 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got fixed in #34633

I suspect it only failed outside of experimental because of the inconsistent entrypoints due to mocking. Once we mocked to a consistent entrypoint, it got fixed.

@eps1lon eps1lon requested review from gnoff and unstubbable February 5, 2026 18:36
@eps1lon eps1lon marked this pull request as ready for review February 5, 2026 18:36
@eps1lon eps1lon merged commit 9a5996a into facebook:main Feb 6, 2026
237 checks passed
@eps1lon eps1lon deleted the sebbie/02-05-_flags_cleanup_enablehalt_ branch February 6, 2026 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed React Core Team Opened by a member of the React Core Team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants