[DevTools] Fix ReactDevToolsBackend module for AMD#35891
Merged
hoxyq merged 1 commit intofacebook:mainfrom Feb 24, 2026
Merged
Conversation
For apps that use AMD, we need to actually `require()` the ReactDevToolsBackend and load it from the AMD module cache. This adds a check for the case where the UMD definiton fell into the AMD branch and only `require()`s in that case. We can't just check if `require` is function because Metro does export a `require` function, but for the Metro case, we wouldn't fall into the AMD branch for UMD.
fullstackhacker
changed the title
hoxyq
approved these changes
Feb 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
For apps that use AMD, we need to actually
require()the ReactDevToolsBackend and load it from the AMD module cache. This adds a check for the case where theReactDevToolsBackendisn't defined globally, and so we load it withrequire().How did you test this change?
Tested through #35886