[test] Add current behavior for faulty onDefaultTransitionIndicator implementation#35928
Open
eps1lon wants to merge 1 commit intofacebook:mainfrom
Conversation
github-actions
bot
added
the
React Core Team
|
Comparing: e0cc720...095d8a8 Critical size changesIncludes critical production bundles, as well as any change greater than 2%:
Significant size changesIncludes any change greater than 0.2%: (No significant changes) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
React catches these and forwards them to
reportErrornot callingonUncaughtError. React won't unmount the root.This feels like the right behavior. Maybe not calling
onUncaughtErroris debatable.Was mostly interested if throwing from
onUncaughtErrorwould be caught at all.