[noop] Fix createContainer argument order in the Fiber implementation#35945
Merged
eps1lon merged 6 commits intofacebook:mainfrom Mar 4, 2026
Merged
Conversation
github-actions
bot
added
the
React Core Team
eps1lon
changed the title
createContainer argument ordercreateContainer argument order in the Fiber implementation
eps1lon
commented
Mar 2, 2026
| jest.restoreAllMocks(); | ||
| }); | ||
|
|
||
| // @gate enableViewTransition || fb |
Collaborator
Author
There was a problem hiding this comment.
Outside of enableViewTransition, <ViewTransition> is rendered as a Scope Component due to how messy feature flags are with switch statements:
react/packages/react-reconciler/src/ReactFiber.js
Lines 625 to 634 in fe1ec4f
This used to just pass the test since react-noop-renderer didn't throw when Scope host config APIs were used. Now we do so the test fails in fb builds that have enableViewTransition off but enableScope on.
unstubbable
approved these changes
Mar 4, 2026
eps1lon
force-pushed
the
sebbie/03-02-_noop_match_fiber_host_config
branch
from
5374ae3 to
05bf806
Compare
Notable `now` and `logRecoverableError` were removed due to being unused by Fiber. The rest is either adding throwing shims for missing host config properties or using the shared shims when the whole feature isn't implemented.
They can't be imported from `react-reconciler` since that package is treated as an external of react-noop-renderer
…s a Scope Component
eps1lon
force-pushed
the
sebbie/03-02-_noop_match_fiber_host_config
branch
from
05bf806 to
8127022
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
...and fix most of the type issues in the Fiber implementation of
react-noop-rendererStacked on #35944
Only addressed the most obvious issues. There's still some issues relating to loosely accessing object properties but those don't feel urgent. Especially because this is a test-only renderer.
The argument order of
createContainerwas the main concern.