[DevTools] feat: display subtree for Activity and dim in hidden mode#36094
Merged
[DevTools] feat: display subtree for Activity and dim in hidden mode#36094
Conversation
hoxyq
force-pushed
the
devtools/activity-hidden
branch
from
e52b290 to
eb0b2d1
Compare
Collaborator
|
I fear that this will make the tree way too busy. Can we collapse hidden subtrees by default? |
Contributor
Author
The tree is already too big on larger modern applications. Yes, I think there is a way to auto-collapse these, will implement that, great idea. |
hoxyq
force-pushed
the
devtools/activity-hidden
branch
from
eb0b2d1 to
a765a61
Compare
Contributor
Author
|
@eps1lon Updated! Screen.Recording.2026-03-20.at.14.05.58.mov |
hoxyq
force-pushed
the
devtools/activity-hidden
branch
from
a765a61 to
52a4ae5
Compare
eps1lon
approved these changes
Mar 23, 2026
Comment on lines
+5302
to
+5305
| // Detect Activity hidden/visible mode changes. | ||
| if ( | ||
| nextFiber.tag === ActivityComponent && | ||
| fiberInstance.kind === FIBER_INSTANCE |
Collaborator
There was a problem hiding this comment.
Should this also check that the previous Fiber was an Activity?
Comment on lines
+5315
to
+5316
| const prevHidden = prevOffscreen.memoizedState !== null; | ||
| const nextHidden = nextOffscreen.memoizedState !== null; |
Collaborator
There was a problem hiding this comment.
Can we use isHiddenOffscreen here?
hoxyq
force-pushed
the
devtools/activity-hidden
branch
from
52a4ae5 to
a0194b3
Compare
hoxyq
force-pushed
the
devtools/activity-hidden
branch
from
a0194b3 to
0b4b19d
Compare
|
Thanks for the update! Looks great—nice catch on handling the hidden mode
for Activity.
…On Mon, Mar 23, 2026, 9:30 AM Ruslan Lesiutin ***@***.***> wrote:
Merged #36094 <#36094> into main.
—
Reply to this email directly, view it on GitHub
<#36094?email_source=notifications&email_token=B7BPWU75DFC4C4AQ5C4UA5D4SFC7VA5CNFSNUABQM5UWIORPF5TWS5BNNB2WEL2JONZXKZKFOZSW45CON52GSZTJMNQXI2LPNYXTEMZYGE3DCNRYGYZTTJTSMVQXG33OVJZXKYTTMNZGSYTFMSSWK5TFNZ2KYZTPN52GK4S7MNWGSY3L#event-23816168639>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/B7BPWU557FSZFT5YJPONJHT4SFC7VAVCNFSM6AAAAACWXAZIV2VHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMRTHAYTMMJWHA3DGOI>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With this change, Components panel will display subtree of the Activity. When it is in hidden mode, the subtree will be dimmed.
Added Jest tests and a sandbox case to
react-devtools-shell.Demo:
Screen.Recording.2026-03-18.at.20.02.48.mov