Skip to content

[Fizz] add additional task reentrancy protections#36291

Merged
gnoff merged 1 commit intofacebook:mainfrom
gnoff:jstory/enhance-reentrant-checks
Apr 16, 2026
Merged

[Fizz] add additional task reentrancy protections#36291
gnoff merged 1 commit intofacebook:mainfrom
gnoff:jstory/enhance-reentrant-checks

Conversation

@gnoff
Copy link
Copy Markdown
Collaborator

@gnoff gnoff commented Apr 16, 2026

The prior fix for finishedTask reentrancy solved an observed failure. This change adds a bit of defensive bookeeping to protect against other theoretical reentrant task finishing that might fail in simlar ways but where we don't have a clear demonstration of the bug.

The prior fix for finishedTask reentrancy solved an observed failure. This change adds a bit of defensive bookeeping to protect against other theoretical reentrant task finishing that might fail in simlar ways but where we don't have a clear demonstration of the bug.
@meta-cla meta-cla bot added the CLA Signed label Apr 16, 2026
@github-actions github-actions bot added the React Core Team Opened by a member of the React Core Team label Apr 16, 2026
@react-sizebot
Copy link
Copy Markdown

Comparing: fe51601...4b02999

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.js = 6.84 kB 6.84 kB +0.05% 1.88 kB 1.88 kB
oss-stable/react-dom/cjs/react-dom-client.production.js = 612.91 kB 612.91 kB = 108.30 kB 108.31 kB
oss-experimental/react-dom/cjs/react-dom.production.js = 6.84 kB 6.84 kB +0.05% 1.88 kB 1.88 kB
oss-experimental/react-dom/cjs/react-dom-client.production.js = 678.85 kB 678.85 kB = 119.27 kB 119.27 kB
facebook-www/ReactDOM-prod.classic.js = 698.58 kB 698.58 kB = 122.74 kB 122.74 kB
facebook-www/ReactDOM-prod.modern.js = 688.90 kB 688.90 kB = 121.12 kB 121.12 kB

Significant size changes

Includes any change greater than 0.2%:

(No significant changes)

Generated by 🚫 dangerJS against 4b02999

@gnoff gnoff merged commit 4b073f4 into facebook:main Apr 16, 2026
241 checks passed
@gnoff gnoff deleted the jstory/enhance-reentrant-checks branch April 16, 2026 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed React Core Team Opened by a member of the React Core Team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants