Add null check before calling fabricSuspendOnActiveViewTransition#36310
Merged
zeyap merged 1 commit intofacebook:mainfrom Apr 17, 2026
Merged
Add null check before calling fabricSuspendOnActiveViewTransition#36310zeyap merged 1 commit intofacebook:mainfrom
zeyap merged 1 commit intofacebook:mainfrom
Conversation
fabricSuspendOnActiveViewTransition may not be available on all versions of nativeFabricUIManager. Guard the call with a null check to prevent crashes on hosts that haven't implemented this method yet.
rubennorte
approved these changes
Apr 17, 2026
|
Comparing: d1727fb...cf09724 Critical size changesIncludes critical production bundles, as well as any change greater than 2%:
Significant size changesIncludes any change greater than 0.2%: (No significant changes) |
github-actions bot
pushed a commit
that referenced
this pull request
Apr 17, 2026
…6310) ## Summary - Adds a null check before calling `fabricSuspendOnActiveViewTransition()` in the Fabric renderer's `suspendOnActiveViewTransition` export - Prevents crashes on hosts where `nativeFabricUIManager` does not yet implement `suspendOnActiveViewTransition` ## Test plan - Verified the change compiles correctly - Hosts with `suspendOnActiveViewTransition` implemented continue to work as before - Hosts without `suspendOnActiveViewTransition` no longer crash when view transitions are active DiffTrain build for [1ddff43](1ddff43)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
fabricSuspendOnActiveViewTransition()in the Fabric renderer'ssuspendOnActiveViewTransitionexportnativeFabricUIManagerdoes not yet implementsuspendOnActiveViewTransitionTest plan
suspendOnActiveViewTransitionimplemented continue to work as beforesuspendOnActiveViewTransitionno longer crash when view transitions are active