fix(build): unblock eslint-plugin-react-hooks Rollup bundle#36311
fix(build): unblock eslint-plugin-react-hooks Rollup bundle#36311ViperDroid wants to merge 2 commits intofacebook:mainfrom
Conversation
|
Hi @ViperDroid! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
78fc7ed to
c038a5a
Compare
- Add @types/babel__code-frame so @rollup/plugin-typescript can typecheck imports of @babel/code-frame during the monorepo build. - Honor bundle.preferBuiltins in @rollup/plugin-node-resolve so Node built-ins (e.g. tty, os) resolve correctly for the hooks ESLint plugin; bundles.js already sets preferBuiltins: true for that package.
c038a5a to
34b58d6
Compare
Made-with: Viper Droid
Summary
How did you test this change?