Skip to content

Suggest correct casing for misspelled credentialless iframe attribute#36322

Merged
hoxyq merged 1 commit intomainfrom
feat/suggest-correct-spelling-for-credentialless
Apr 21, 2026
Merged

Suggest correct casing for misspelled credentialless iframe attribute#36322
hoxyq merged 1 commit intomainfrom
feat/suggest-correct-spelling-for-credentialless

Conversation

@vmx906
Copy link
Copy Markdown
Contributor

@vmx906 vmx906 commented Apr 21, 2026

Summary

Follow-up to #36148 (which added credentialless as a recognized boolean attribute for iframes). Adds credentialless to possibleStandardNames so React's dev warning can suggest the correct casing when users write it as Credentialless (or another incorrect case). Includes an SSR test asserting the "Did you mean credentialless?" warning fires.

Test plan

  • yarn test ReactDOMComponent passes, including the new should warn about incorrect casing on the credentialless property (ssr) case

@vmx906 vmx906 requested a review from hoxyq April 21, 2026 09:25
@meta-cla meta-cla Bot added the CLA Signed label Apr 21, 2026
@hoxyq hoxyq merged commit 94643c3 into main Apr 21, 2026
466 of 468 checks passed
@hoxyq hoxyq deleted the feat/suggest-correct-spelling-for-credentialless branch April 21, 2026 09:33
github-actions Bot pushed a commit that referenced this pull request Apr 21, 2026
…#36322)

## Summary

Follow-up to #36148 (which added credentialless as a recognized boolean
attribute for iframes). Adds credentialless to possibleStandardNames so
React's dev warning can suggest the correct casing when users write it
as Credentialless (or another incorrect case). Includes an SSR test
asserting the "Did you mean credentialless?" warning fires.

 ## Test plan

- yarn test ReactDOMComponent passes, including the new should warn
about incorrect casing on the credentialless property (ssr) case

DiffTrain build for [94643c3](94643c3)
github-actions Bot pushed a commit that referenced this pull request Apr 21, 2026
…#36322)

## Summary

Follow-up to #36148 (which added credentialless as a recognized boolean
attribute for iframes). Adds credentialless to possibleStandardNames so
React's dev warning can suggest the correct casing when users write it
as Credentialless (or another incorrect case). Includes an SSR test
asserting the "Did you mean credentialless?" warning fires.

 ## Test plan

- yarn test ReactDOMComponent passes, including the new should warn
about incorrect casing on the credentialless property (ssr) case

DiffTrain build for [94643c3](94643c3)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants