Fix typos in react-dom dev warning messages (ecountered, ocurred, deduplciate, Recieved)#36349
Fix typos in react-dom dev warning messages (ecountered, ocurred, deduplciate, Recieved)#36349creazyfrog wants to merge 1 commit intofacebook:mainfrom
Conversation
Corrects three misspellings in DEV-only warning strings and their matching test expectations: - "ecountered" → "encountered" (ReactFizzConfigDOM.js, test assertions) - "ocurred" → "occurred" (ReactFizzConfigDOM.js, test assertions) - "deduplciate" → "deduplicate" (ReactFizzConfigDOM.js, ReactDOMResourceValidation.js, test assertions) - "Recieved" → "Received" (ReactDOMFloat-test.js, ReactDOMFizzServer-test.js) No behavior change — DEV-only warning text and matching test expectations only. Fixes facebook#36320
|
Hi @creazyfrog! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
Summary
Fixes #36320
PR has been raised with the help of Claude Code
Corrects four misspellings in DEV-only warning strings emitted by
react-dom-bindings, along with their matching test expectations:ecounteredencounteredReactFizzConfigDOM.js,ReactDOMResourceValidation.js, testsocurredoccurredReactFizzConfigDOM.js, testsdeduplciatededuplicateReactFizzConfigDOM.js,ReactDOMResourceValidation.js, testsRecievedReceivedReactDOMFloat-test.js,ReactDOMFizzServer-test.jsFiles changed:
packages/react-dom-bindings/src/server/ReactFizzConfigDOM.jspackages/react-dom-bindings/src/shared/ReactDOMResourceValidation.jspackages/react-dom/src/__tests__/ReactDOMFloat-test.jspackages/react-dom/src/__tests__/ReactDOMFizzServer-test.jsNo behavior change — DEV-only warning text and matching test expectations only.
How did you test this change?
grep -rnacrosspackages/— none remain after the fix.yarn prettieron changed files — no formatting changes needed.yarn linc— Lint passed for changed files.