fix: support autoFocus on anchor (<a>) elements#36351
Open
creazyfrog wants to merge 1 commit intofacebook:mainfrom
Open
fix: support autoFocus on anchor (<a>) elements#36351creazyfrog wants to merge 1 commit intofacebook:mainfrom
creazyfrog wants to merge 1 commit intofacebook:mainfrom
Conversation
The autofocus attribute is a global HTML attribute applicable to any focusable element per the HTML spec: https://developer.mozilla.org/en-US/docs/Web/HTML/Global_attributes/autofocus React's finalizeInitialChildren and commitMount only handled autoFocus for button, input, select, and textarea. This adds case 'a': to both switch statements so anchor tags are focused on mount when autoFocus is set, consistent with how form controls are handled. Fixes facebook#35656
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #35656
PR has been raised with the help of Claude Code
The
autofocusattribute is a global HTML attribute applicable to any focusable element per the HTML spec. React'sautoFocusprop was only handled forbutton,input,select, andtextareaelements. Anchor tags (<a>) were silently ignored.This PR adds
case 'a':to the two switch statements inReactFiberConfigDOM.jsthat controlautoFocusbehaviour:finalizeInitialChildren(line ~701) — tells React whethercommitMountneeds to be called for this element. Adding'a'here ensures the mount phase is scheduled whenautoFocusis set.commitMount(line ~894) — calls.focus()on the DOM node. Adding'a'here (withHTMLAnchorElementin the Flow cast) performs the actual focus.File changed:
packages/react-dom-bindings/src/client/ReactFiberConfigDOM.jsBefore:
After:
How did you test this change?
<a href="..." autoFocus>now falls through to theautoFocuscheck in bothfinalizeInitialChildrenandcommitMount, matching the behaviour of<button autoFocus>.yarn prettier— no formatting changes needed.yarn linc— Lint passed for changed files.