Skip to content

[Reconciler] Fix: "Should not already be working" in Firefox after a breakpoint/alert #17355 #36403

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
prashant3030223 wants to merge 1 commit into
base: main
Choose a base branch
from
+9 −3
Open

[Reconciler] Fix: "Should not already be working" in Firefox after a breakpoint/alert #17355 #36403

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions packages/react-reconciler/src/ReactFiberRootScheduler.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -193,6 +193,11 @@ function flushSyncWorkAcrossRoots_impl(
return;
}

const executionContext = getExecutionContext();
if ((executionContext & (RenderContext | CommitContext)) !== NoContext) {
return;
}

if (!mightHavePendingSyncWork) {
// Fast path. There's no sync work to do.
return;
Expand Down Expand Up @@ -527,9 +532,10 @@ function performWorkOnRootViaSchedulerTask(
trackSchedulerEvent();
}

if (hasPendingCommitEffects()) {
// We are currently in the middle of an async committing (such as a View Transition).
// We could force these to flush eagerly but it's better to defer any work until
const executionContext = getExecutionContext();
if ((executionContext & (RenderContext | CommitContext)) !== NoContext) {
// We are currently in the middle of a render or commit. We could force
// these to flush eagerly but it's better to defer any work until
// it finishes. This may not be the same root as we're waiting on.
// TODO: This relies on the commit eventually calling ensureRootIsScheduled which
// always calls processRootScheduleInMicrotask which in turn always loops through
Expand Down