Skip to content

Updating es5-shim URL#3641

Merged
zpao merged 1 commit intofacebook:masterfrom
ljharb:patch-1
Apr 9, 2015
Merged

Updating es5-shim URL#3641
zpao merged 1 commit intofacebook:masterfrom
ljharb:patch-1

Conversation

@ljharb
Copy link
Copy Markdown
Contributor

@ljharb ljharb commented Apr 9, 2015

No description provided.

@facebook-github-bot
Copy link
Copy Markdown
Contributor

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at cla@fb.com. Thanks!

@facebook-github-bot
Copy link
Copy Markdown
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we perhaps not say "kriskowal's es5-shim" (here and above)?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought about that, but even though I own and maintain it now, I saw no need to remove Kris' credit for creating it and building it up in the first place. These are your docs, so it's your call :-)

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ohai, didn't make the connection to you when I was looking at the repo :) Fair enough. And of course, thanks!

zpao added a commit that referenced this pull request Apr 9, 2015
@zpao zpao merged commit 9d6b119 into facebook:master Apr 9, 2015
zpao added a commit that referenced this pull request Apr 13, 2015
@ljharb ljharb deleted the patch-1 branch January 17, 2016 21:40
dilberx pushed a commit to dilberx/react that referenced this pull request Apr 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants