added owner in invalid style invariant error#4176
Closed
bloodyowl wants to merge 1 commit intofacebook:masterfrom
bloodyowl:feat.style-warning
Closed
added owner in invalid style invariant error#4176bloodyowl wants to merge 1 commit intofacebook:masterfrom bloodyowl:feat.style-warning
bloodyowl wants to merge 1 commit intofacebook:masterfrom
bloodyowl:feat.style-warning
Conversation
Member
There was a problem hiding this comment.
Formatting feels off here. Can we assign owner before the invariant call and use that (can also use a template string instead of concatting the getName(), it'll fit on 1 line when we have owner)
Member
|
#4482 happened so closing this out. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #4168