-
Notifications
You must be signed in to change notification settings - Fork 51.1k
#381 - listen to events on demand #462
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
47 commits
Select commit
Hold shift + click to select a range
514f9a3
#381 - listen to events on demand: Initial work to make sure I have t…
SanderSpies 7972f27
Merge branch 'master' of https://github.com/facebook/react into on-de…
SanderSpies f952372
On demand events are now working.
SanderSpies f16a6c8
Merge branch 'master' of https://github.com/facebook/react into on-de…
SanderSpies 193227a
Merge branch 'master' of https://github.com/facebook/react into on-de…
SanderSpies 8719275
Merge branch 'master' of https://github.com/facebook/react into on-de…
SanderSpies b052c45
Merge branch 'master' of https://github.com/facebook/react into on-de…
SanderSpies 38b983e
Merge branch 'master' of https://github.com/facebook/react into on-de…
SanderSpies 104a249
Make ReactEventTopLevelCallback-test pass
sophiebits 8ef5049
- Implemented tests
SanderSpies 3efd107
Merge branch 'master' of https://github.com/facebook/react into on-de…
SanderSpies 57fdef1
Merge branch 'master' of https://github.com/facebook/react into on-de…
SanderSpies 3bec953
Merge branch 'master' of https://github.com/facebook/react into on-de…
SanderSpies ce48191
Merge branch 'master' of https://github.com/facebook/react into on-de…
SanderSpies 0b9973f
Merge branch 'master' of https://github.com/facebook/react into on-de…
SanderSpies d3a880d
Merge branch 'master' of https://github.com/facebook/react into on-de…
SanderSpies 2437586
Revert "Merge branch 'master' of https://github.com/facebook/react in…
SanderSpies 000f7ab
Merge branch 'master' of https://github.com/facebook/react into HEAD
SanderSpies 1336888
Revert "Merge branch 'master' of https://github.com/facebook/react in…
SanderSpies 7d704c3
Changes related to balpert's comments
SanderSpies 4268841
Revert "Merge branch 'master' of https://github.com/facebook/react in…
SanderSpies 22df2b6
Sanitizing
SanderSpies f3caf23
Sanitizing
SanderSpies 8d6fb7e
Sanitizing
SanderSpies db2116f
sanitizing
SanderSpies 686e817
Sanitizing
SanderSpies ca7b131
Added git ignore for .idea
SanderSpies 210778a
sanitizing
SanderSpies 0389251
Accessing non-existent property
SanderSpies 98bb7fc
Renaming variables, completing doc.
SanderSpies 6be9de5
Now it actually works.
SanderSpies 9b2062b
Ordering
SanderSpies 101be9f
Merge branch 'master' of https://github.com/facebook/react into on-de…
SanderSpies a45dbd5
Merge branch 'master' of https://github.com/facebook/react into on-de…
SanderSpies 8f294c8
- removed all the delete document['_reactTopListenersID'];
SanderSpies e9b7e57
Staying closer to the 80 character limit
SanderSpies 4c73f3d
Naming + code formatting
SanderSpies a892ec3
Making comment clearer
SanderSpies 020e50a
Simplifying SimpleEventPlugin
SanderSpies 9688444
Merge branch 'master' of https://github.com/facebook/react into on-de…
SanderSpies 3f4d737
Merge branch 'master' of https://github.com/facebook/react into on-de…
SanderSpies 87c33fb
Merge branch 'master' of https://github.com/facebook/react into on-de…
SanderSpies 33d853d
Merge branch 'master' of https://github.com/facebook/react into on-de…
SanderSpies d32cf27
Merge branch 'master' of https://github.com/facebook/react into on-de…
SanderSpies 38f21b8
Accidentally pushed testing code
SanderSpies 98e6f96
Implemented several requested changes
SanderSpies 4e47221
implemented getListeningForDocument
SanderSpies File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could the logic here to find the container and execute
listenTobe put intoReactEventEmitter.putListener? Then it doesn't even have to be exposed onReactEventEmitterand could be re-used below.