Fixed some comment punctuation in ReactDOMComponent.js#5102
Merged
jimfb merged 1 commit intofacebook:masterfrom Oct 9, 2015
Merged
Fixed some comment punctuation in ReactDOMComponent.js#5102jimfb merged 1 commit intofacebook:masterfrom
jimfb merged 1 commit intofacebook:masterfrom
Conversation
Contributor
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at cla@fb.com. Thanks! |
Contributor
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
Contributor
|
Sure, can you squash these two commits into a single commit? |
Contributor
Author
|
@jimfb Just squashed the two commits into a single commit! |
Contributor
|
Looks good, thanks! |
jimfb
added a commit
that referenced
this pull request
Oct 9, 2015
Fixed some comment punctuation in ReactDOMComponent.js
jimfb
added
Component: Documentation & Website
and removed
GH Review: review-needed
labels
jimfb
added a commit
that referenced
this pull request
Oct 9, 2015
Fixed some comment punctuation in ReactDOMComponent.js (cherry picked from commit 1a7c0a4)
Member
|
Bah, this isn't the website and didn't need to get merged to stable… |
dilberx
pushed a commit
to dilberx/react
that referenced
this pull request
Apr 15, 2026
Fixed some comment punctuation in ReactDOMComponent.js (cherry picked from commit a03e904)
dilberx
pushed a commit
to dilberx/react
that referenced
this pull request
Apr 15, 2026
This reverts commit 840286d.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.