Skip to content

Remove deprecated function from tests #6536

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gaearon merged 1 commit into from
Oct 24, 2016
Merged

Remove deprecated function from tests #6536

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions src/renderers/shared/stack/reconciler/__tests__/ReactCompositeComponent-test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,17 +91,17 @@ describe('ReactCompositeComponent', function() {

reactComponentExpect(instance)
.expectRenderedChild()
.toBeDOMComponentWithTag('a');
.toBeComponentOfType('a');

instance._toggleActivatedState();
reactComponentExpect(instance)
.expectRenderedChild()
.toBeDOMComponentWithTag('b');
.toBeComponentOfType('b');

instance._toggleActivatedState();
reactComponentExpect(instance)
.expectRenderedChild()
.toBeDOMComponentWithTag('a');
.toBeComponentOfType('a');
});

it('should not thrash a server rendered layout with client side one', () => {
Expand Down Expand Up @@ -134,7 +134,7 @@ describe('ReactCompositeComponent', function() {
ReactTestUtils.Simulate.click(renderedChild);
reactComponentExpect(instance)
.expectRenderedChild()
.toBeDOMComponentWithTag('b');
.toBeComponentOfType('b');
});

it('should rewire refs when rendering to different child types', function() {
Expand Down
6 changes: 3 additions & 3 deletions src/renderers/shared/stack/reconciler/__tests__/ReactCompositeComponentDOMMinimalism-test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ describe('ReactCompositeComponentDOMMinimalism', function() {
.expectRenderedChild()
.toBeCompositeComponentWithType(LowerLevelComposite)
.expectRenderedChild()
.toBeDOMComponentWithTag('div')
.toBeComponentOfType('div')
.toBeDOMComponentWithNoChildren();
};
});
Expand Down Expand Up @@ -97,10 +97,10 @@ describe('ReactCompositeComponentDOMMinimalism', function() {
.expectRenderedChild()
.toBeCompositeComponentWithType(LowerLevelComposite)
.expectRenderedChild()
.toBeDOMComponentWithTag('div')
.toBeComponentOfType('div')
.toBeDOMComponentWithChildCount(1)
.expectRenderedChildAt(0)
.toBeDOMComponentWithTag('ul')
.toBeComponentOfType('ul')
.toBeDOMComponentWithNoChildren();
});

Expand Down
10 changes: 0 additions & 10 deletions src/test/reactComponentExpect.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -167,16 +167,6 @@ Object.assign(reactComponentExpectInternal.prototype, {
return this;
},

/**
* @deprecated
* @see toBeComponentOfType
*/
toBeDOMComponentWithTag: function(tag) {
this.toBeDOMComponent();
expect(this.instance().tagName).toBe(tag.toUpperCase());
return this;
},

/**
* Check that internal state values are equal to a state of expected values.
*/
Expand Down