Update to Jest 12. Codemod to new Jest APIs.#6620
Merged
cpojer merged 1 commit intofacebook:masterfrom Apr 28, 2016
Merged
Conversation
ghost
added
Contributor
|
The unit test expectation matches what the browser does, so it looks like a jsdom bug. |
Member
|
This is just the jest update, not the Jasmine 2 update correct? |
Contributor
Author
|
yes. Waiting for the jsdom fix here: jsdom/jsdom@236caae |
cpojer
changed the title
|
@cpojer updated the pull request. |
Contributor
|
@cpojer updated the pull request. |
|
@cpojer updated the pull request. |
cpojer
force-pushed
the
master
branch
2 times, most recently
from
7b190ad to
9fe5895
Compare
| grunt.log.writeln('running jest (this may take a while)'); | ||
|
|
||
| var args = ['--harmony', path.join('node_modules', 'jest-cli', 'bin', 'jest')]; | ||
| var args = ['--harmony', path.join('node_modules', 'jest-cli', 'bin', 'jest'), '--runInBand']; |
Contributor
Author
|
@cpojer updated the pull request. |
zpao
pushed a commit
that referenced
this pull request
May 10, 2016
Update to Jest 12. Codemod to new Jest APIs. (cherry picked from commit d07b554)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is one test failing right now. Pretty sure it is because we updated to jsdom 8. Will look into this tomorrow unless anyone has some ideas – seems like the multiple defaultValues test is failing in ReactDOMSelect – is this a bug in React or jsdom?