Merged
Conversation
ghost
added
| <h3>Virtual DOM</h3> | ||
| <p> | ||
| React abstracts away the DOM from you, giving a simpler programming model and better performance. React can also render on the server using Node, and it can power native apps using <a href="https://facebook.github.io/react-native/">React Native</a>. | ||
| React abstracts the DOM away from you, giving a simpler programming model and better performance. React can also render on the server using Node, and it can power native apps using <a href="https://facebook.github.io/react-native/">React Native</a>. |
Contributor
There was a problem hiding this comment.
I feel like the "from you" is what makes this sentence awkward. With the "from you", both sentences read awkwardly. Without the "from you", both versions seem fine. Maybe the correct fix here is to remove the "from you" rather than moving the "away".
Thoughts @zpao?
Contributor
Author
There was a problem hiding this comment.
Sounds good to me, @jimfb.
After some searching, "abstracts away [the DOM]" seems more popular - would "abstracts the DOM away" make more sense?
|
@wub updated the pull request. |
Contributor
|
Thanks! |
zpao
pushed a commit
that referenced
this pull request
May 16, 2016
* Fix grammar in README * Change DOM abstraction grammar on homepage (cherry picked from commit 01b060d)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.