Merged
Conversation
Summary: The only callsite left was removed here: facebook@e8af100#commitcomment-17570210 but the code to handle it remained. Test Plan: tbgs and ibgs, make sure there's no callsites. Reviewers: @jimfb, @spicyj, @sebmarkbage
Collaborator
|
lgtm |
Contributor
Author
|
What's the next step? Do I just click the merge button? |
ghost
added
the
Collaborator
|
Please also give it a semver label (semver-patch) and milestone (15.y.z since it doesn't need to be in any particular release), then squash and merge. |
Contributor
|
Nice. I think getNodeHandle in RN was the last one to need this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The only callsite left was removed here: e8af100#commitcomment-17570210 but the code to handle it remained.
Test Plan:
tbgs and ibgs, make sure there's no callsites.
Reviewers: @jimfb, @spicyj, @sebmarkbage