Fix Japanese/Italian/Korean tutorials#7020
Merged
keyz merged 3 commits intofacebook:masterfrom Jun 12, 2016
serima:doc/fix-japanese-tutorial
Merged
Fix Japanese/Italian/Korean tutorials#7020keyz merged 3 commits intofacebook:masterfrom serima:doc/fix-japanese-tutorial
keyz merged 3 commits intofacebook:masterfrom
serima:doc/fix-japanese-tutorial
Conversation
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at cla@fb.com. Thanks! |
ghost
added
the
Contributor
Author
|
signed. |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
Contributor
|
Thanks! While we are here, would you mind also fixing |
Contributor
|
@serima updated the pull request. |
Contributor
Author
|
@keyanzhang thank you for your review. |
Contributor
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Go through the drill, got a following error.
But English version is right.