Minify both before and after browserify#736
Merged
petehunt merged 2 commits intofacebook:masterfrom Dec 29, 2013
Merged
Conversation
grunt/config/browserify.js
Outdated
Contributor
There was a problem hiding this comment.
why not just use uglifyify?
Collaborator
Author
There was a problem hiding this comment.
because I didn't know about it!
petehunt
added a commit
that referenced
this pull request
Dec 29, 2013
Minify both before and after browserify
josephsavona
added a commit
that referenced
this pull request
May 15, 2024
* handle jsx fragments * update effects for jsx fragments
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Excludes
ReactDefaultPerfandperformanceNowfrom the minified build, so we save bytes. Looks like there are a few other minor differences because uglifyjs isn't quite idempotent but they appear to be harmless.Feels silly but I don't think there's another way. (We need to run uglify after as well so that require, module, exports are minified)