[docs] Use appropriately sized og:image#7417
Merged
zpao merged 1 commit intofacebook:masterfrom Aug 3, 2016
Merged
Conversation
Also runs through Imageoptim for smaller size.
zpao
added
Documentation: needs merge to stable
and removed
Documentation: needs merge to stable
labels
zpao
added a commit
that referenced
this pull request
Aug 5, 2016
Also runs through Imageoptim for smaller size. (cherry picked from commit b910a14)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I helped somebody with sizing images to avoid cropping on FB and realized we didn't even follow the recommended guidelines. Our share attachments on FB and the preview in composer were always suboptimal - a small square or scaled/cropped image, respectively.
This changes it to use the recommended minimum size of 1200x630. I just kept it minimal, keeping the logo at the same size and adding space around. It still doesn't say "React" anywhere but I think that's ok - the rest of the attachment does.
Before
Composer:
Story:
After
Composer:
Story:
