Skip to content

[Fiber] Assign ReactTypeOfSideEffect to ReactFiber.Fiber.effectTag correctly #8173

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gaearon merged 1 commit into from
Nov 1, 2016
Merged

[Fiber] Assign ReactTypeOfSideEffect to ReactFiber.Fiber.effectTag correctly #8173

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 2 additions & 6 deletions src/renderers/shared/fiber/ReactChildFiber.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,6 @@ var {
} = require('ReactCoroutine');

var ReactFiber = require('ReactFiber');
var ReactPriorityLevel = require('ReactPriorityLevel');
var ReactReifiedYield = require('ReactReifiedYield');
var ReactTypeOfSideEffect = require('ReactTypeOfSideEffect');
var ReactTypeOfWork = require('ReactTypeOfWork');
Expand Down Expand Up @@ -56,10 +55,7 @@ const {
} = ReactTypeOfWork;

const {
NoWork,
} = ReactPriorityLevel;

const {
NoEffect,
Placement,
Deletion,
} = ReactTypeOfSideEffect;
Expand Down Expand Up @@ -179,7 +175,7 @@ function ChildReconciler(shouldClone, shouldTrackSideEffects) {
// we're reconciling at a lower priority that means that this was
// down-prioritized.
fiber.pendingWorkPriority = priority;
fiber.effectTag = NoWork;
fiber.effectTag = NoEffect;
fiber.index = 0;
fiber.sibling = null;
return fiber;
Expand Down
2 changes: 1 addition & 1 deletion src/renderers/shared/fiber/ReactFiberScheduler.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,7 +129,7 @@ module.exports = function<T, P, I, TI, C>(config : HostConfig<T, P, I, TI, C>) {
commitInsertion(effectfulFiber);
// Clear the effect tag so that we know that this is inserted, before
// any life-cycles like componentDidMount gets called.
effectfulFiber.effectTag = NoWork;
effectfulFiber.effectTag = NoEffect;
break;
}
case PlacementAndUpdate: {
Expand Down