Clarity on constructor of Board object for tutorial.md#8224
Clarity on constructor of Board object for tutorial.md#8224lacker merged 2 commits intofacebook:masterfrom
Conversation
Is it possible to be more clear here? This implies that we are removing the constructor from GAME, and not board (which is what I believe the author is trying to say). It took me several reads to understand. With this edit, it is now clear that the adjustment is being made to -Board- and not to -Game-
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at cla@fb.com. Thanks! If you are contributing on behalf of someone else (eg your employer): the individual CLA is not sufficient - use https://developers.facebook.com/opensource/cla?type=company instead. Contact cla@fb.com if you have any questions. |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
|
Yes... I think you are correct here. Also the later part of this sentence mentions "Board" when I think it's clearer to just mention "Square" so I tweaked the docs there as well. Thanks for submitting this pull request! |
* Update tutorial.md Is it possible to be more clear here? This implies that we are removing the constructor from GAME, and not board (which is what I believe the author is trying to say). It took me several reads to understand. With this edit, it is now clear that the adjustment is being made to -Board- and not to -Game- * also remove "for Board earlier"
* Update tutorial.md Is it possible to be more clear here? This implies that we are removing the constructor from GAME, and not board (which is what I believe the author is trying to say). It took me several reads to understand. With this edit, it is now clear that the adjustment is being made to -Board- and not to -Game- * also remove "for Board earlier"
* Update tutorial.md Is it possible to be more clear here? This implies that we are removing the constructor from GAME, and not board (which is what I believe the author is trying to say). It took me several reads to understand. With this edit, it is now clear that the adjustment is being made to -Board- and not to -Game- * also remove "for Board earlier"
Before submitting a pull request, please make sure the following is done...
master.npm test).npm run lint) - we've done our best to make sure these rules match our internal linting guidelines.Is it possible to be more clear here?
This implies that we are removing the constructor from GAME, and not board (which is what I believe the author is trying to say).
It took me several reads to understand.
With this edit, it is now clear that the adjustment is being made to -Board- and not to -Game-