Skip to content

Change test assertion depending on a feature flag #8306

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gaearon merged 1 commit into from
Nov 22, 2016
Merged

Change test assertion depending on a feature flag #8306

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions src/isomorphic/classic/element/__tests__/ReactElement-test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@
var React;
var ReactDOM;
var ReactTestUtils;
var ReactDOMFeatureFlags;

describe('ReactElement', () => {
var ComponentClass;
Expand All @@ -30,6 +31,7 @@ describe('ReactElement', () => {
React = require('React');
ReactDOM = require('ReactDOM');
ReactTestUtils = require('ReactTestUtils');
ReactDOMFeatureFlags = require('ReactDOMFeatureFlags');
// NOTE: We're explicitly not using JSX here. This is intended to test
// classic JS without JSX.
ComponentClass = React.createClass({
Expand Down Expand Up @@ -266,9 +268,9 @@ describe('ReactElement', () => {
React.createElement(Wrapper)
);

if (typeof element._owner.tag === 'number') { // Fiber reconciler
if (ReactDOMFeatureFlags.useFiber) {
expect(element._owner.stateNode).toBe(instance);
} else { // Stack reconciler
} else {
expect(element._owner.getPublicInstance()).toBe(instance);
}
});
Expand Down