Skip to content

Fix isFiberMounted exports #8465

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sophiebits merged 1 commit into from
Nov 30, 2016
Merged

Fix isFiberMounted exports #8465

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions src/renderers/shared/fiber/ReactFiberTreeReflection.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ var MOUNTING = 1;
var MOUNTED = 2;
var UNMOUNTED = 3;

function isFiberMounted(fiber : Fiber) : number {
function isFiberMountedImpl(fiber : Fiber) : number {
let node = fiber;
if (!fiber.alternate) {
// If there is no alternate, this might be a new tree that isn't inserted
Expand Down Expand Up @@ -61,19 +61,21 @@ function isFiberMounted(fiber : Fiber) : number {
// that has been unmounted.
return UNMOUNTED;
}
exports.isFiberMounted = isFiberMounted;
exports.isFiberMounted = function(fiber : Fiber) : boolean {
return isFiberMountedImpl(fiber) === MOUNTED;
};

exports.isMounted = function(component : ReactComponent<any, any, any>) : boolean {
var fiber : ?Fiber = ReactInstanceMap.get(component);
if (!fiber) {
return false;
}
return isFiberMounted(fiber) === MOUNTED;
return isFiberMountedImpl(fiber) === MOUNTED;
};

exports.findCurrentHostFiber = function(parent : Fiber) : Fiber | null {
// First check if this node itself is mounted.
const state = isFiberMounted(parent, true);
const state = isFiberMountedImpl(parent, true);
if (state === UNMOUNTED) {
invariant(
false,
Expand Down