Closed
Conversation
quantizor
reviewed
Dec 25, 2016
| .idea | ||
| *.iml | ||
| .vscode | ||
| yarn.lock |
Contributor
There was a problem hiding this comment.
Why would you ignore yarn.lock? The whole point of it is to be included to ensure specific versions of things are installed.
Contributor
There was a problem hiding this comment.
Yes, please remove this, we explicitly made sure to check this in #7957
aweary
reviewed
Dec 27, 2016
| ReactNoop.flushDeferredPri(7 + 5 + 5); | ||
| expect(fooCalled).toBe(true); | ||
| expect(barCalled).toBe(true); | ||
| expect(renderCallbackCalled).toBe(false); |
Contributor
|
Since there's been no follow-up, and the test changes are non-critical (and possibly unwanted) I'm going to go ahead and close this out. Thanks for the effort though @zzz6519003! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.