Stack handle error#8864
Closed
edvinerikson wants to merge 2 commits into
Closed
Conversation
Contributor
Author
|
http://codepen.io/anon/pen/mRMXEG?editors=0011 open the console tab and you will see that it only logs |
Collaborator
|
A boundary does not catch its own errors. It only catches errors in its children. Errors in the boundary itself will propagate up to the next parent boundary. (Or top level.) |
Contributor
Author
|
Ah, yeah that makes sense! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Not sure how I would structure the test for it or even if the fix is the correct place to fix it.
Also fiber seems to crash, might be that the state update is missed in unstable_handleError (maybe that is accurate)
Before submitting a pull request, please make sure the following is done:
master.npm test).npm run lint).npm run flow)../scripts/fiber/record-testsbefore submitting the pull request, and commit the resulting changes.