Skip to content

Fix incorrect markup for ie10 in docs footer.#8886

Merged
aweary merged 3 commits intofacebook:masterfrom
Rastopyr:master
Jan 31, 2017
Merged

Fix incorrect markup for ie10 in docs footer.#8886
aweary merged 3 commits intofacebook:masterfrom
Rastopyr:master

Conversation

@Rastopyr
Copy link
Copy Markdown
Contributor

This PR resolve #8875

As noted by the @nhunzaker, scss not contain -ms prefixes for flexbox. This PR add their.

@Rastopyr Rastopyr changed the title Fix incorrect markup for ie10. Fix incorrect markup for ie10 in docs footer. Jan 30, 2017
@nhunzaker
Copy link
Copy Markdown
Contributor

Looks like the CI fail is unrelated. Happy to do browser testing on this, but I'm not sure how to setup the website locally.

Gonna figure that out...

@Rastopyr
Copy link
Copy Markdown
Contributor Author

@nhunzaker

Looks like this related with fail in #8884. But @gaearon approved it.

@aweary
Copy link
Copy Markdown
Contributor

aweary commented Jan 30, 2017

That's fine for now. If we can verify that this fixes #8875 I can just merge, and fix CI later

@aweary aweary self-assigned this Jan 30, 2017
@nhunzaker
Copy link
Copy Markdown
Contributor

nhunzaker commented Jan 30, 2017

Checked in:

  • IE10,11,14
  • Safari 10
  • Chrome (Latest)
  • Firefox (Latest)
  • Opera (Latest)

Looks legit to me!

@aweary
Copy link
Copy Markdown
Contributor

aweary commented Jan 31, 2017

Thanks @Rastopyr and @nhunzaker!

@aweary aweary merged commit 466bb4f into facebook:master Jan 31, 2017
gaearon pushed a commit that referenced this pull request Feb 2, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

your website page not working properly in ie10

5 participants