Convert problematic let declarations to var#8891
Closed
sophiebits wants to merge 1 commit intofacebook:masterfrom
Closed
Convert problematic let declarations to var#8891sophiebits wants to merge 1 commit intofacebook:masterfrom
let declarations to var#8891sophiebits wants to merge 1 commit intofacebook:masterfrom
Conversation
Test Plan: Patch in babel/babel#5236, run `grunt build:modules` with no errors.
Collaborator
Author
|
Most of these aren't actually necessary after babel/babel#5246. Will wait a bit and see if that gets merged. (Though I guess we won't update immediately at FB.) |
Collaborator
Author
|
Abandoning in favor of #9002. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test Plan: Patch in babel/babel#5236, run
grunt build:moduleswith no errors.