Skip to content

Build command refactor: extractErrors -> extract-errors #9777

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
trueadm merged 2 commits into from
May 25, 2017
Merged

Build command refactor: extractErrors -> extract-errors #9777

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c16eea8
extractErrors -> extract-errors
trueadm May 25, 2017
c43e771
merge conflict
trueadm May 25, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion scripts/circleci/build.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,5 +2,5 @@

set -e

npm run build -- --extractErrors
npm run build -- --extract-errors
git checkout -- scripts/error-codes/codes.json
2 changes: 1 addition & 1 deletion scripts/release-manager/Readme.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,7 +149,7 @@ If you’re just cutting an alpha, you should skip it.
Run this so that `scripts/error-codes/codes.json` is up to date:

```
npm run build -- --extractErrors
npm run build -- --extract-errors
```

Check `git diff`. Do changes, if any, look sensible?
Expand Down
6 changes: 3 additions & 3 deletions scripts/rollup/build.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -294,7 +294,7 @@ function getPlugins(
const plugins = [
babel(updateBabelConfig(babelOpts, bundleType)),
alias(
Modules.getAliases(paths, bundleType, isRenderer, argv.extractErrors)
Modules.getAliases(paths, bundleType, isRenderer, argv['extract-errors'])
),
];

Expand Down Expand Up @@ -490,9 +490,9 @@ rimraf('build', () => {
console.log(Stats.printResults());
// save the results for next run
Stats.saveResults();
if (argv.extractErrors) {
if (argv['extract-errors']) {
console.warn(
'\nWarning: this build was created with --extractErrors enabled.\n' +
'\nWarning: this build was created with --extract-errors enabled.\n' +
'this will result in extremely slow builds and should only be\n' +
'used when the error map needs to be rebuilt.\n'
);
Expand Down