Remove ensureScrollValueMonitoring#9819
Merged
nhunzaker merged 1 commit intofacebook:masterfrom Jun 1, 2017
Merged
Conversation
I never actually removed the rest of this when I got rid of ViewportMetrics. We no longer need `ReactDOMEventListener.monitorScrollValue`.
gaearon
approved these changes
May 31, 2017
Contributor
Author
|
@gaearon sorry if this is a bit skiddish, but okay to merge? |
Collaborator
|
Yep, if somebody approves, merge away. |
Contributor
Author
|
👍 |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Working through #9333 I discovered that I never actually removed the rest of
ViewportMetricsin #9290. We no longer needReactDOMEventListener.monitorScrollValue, or its trail of stuff.😨 🙏 😨 🙏