[WIP] Improve build's handling of externals better#9850
Closed
trueadm wants to merge 1 commit intofacebook:masterfrom
Closed
[WIP] Improve build's handling of externals better#9850trueadm wants to merge 1 commit intofacebook:masterfrom
trueadm wants to merge 1 commit intofacebook:masterfrom
Conversation
Collaborator
|
Not sure I understand why this helps. Let's revisit it later. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a follow on from comments in this PR:
#9790
Currently, the build can be quite hard to reason with given un-used externals don't give errors. This PR adds an exclusion list and forces unused external modules to throw an error - prompting that something needs to change.
This is still a WIP as I'm not sure this is 100% the best route for this still.