Use container for github actions #943
Closed
+74
−32
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D77059596 |
xuhdev
added a commit
to xuhdev/redex
that referenced
this pull request
Jun 21, 2025
Summary: Rollback Plan: Differential Revision: D77059596
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D77059596 |
xuhdev
added a commit
to xuhdev/redex
that referenced
this pull request
Jun 21, 2025
Summary: Rollback Plan: Differential Revision: D77059596
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D77059596 |
xuhdev
added a commit
to xuhdev/redex
that referenced
this pull request
Jun 21, 2025
Summary: Rollback Plan: Differential Revision: D77059596
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D77059596 |
xuhdev
added a commit
to xuhdev/redex
that referenced
this pull request
Jun 21, 2025
Summary: Rollback Plan: Differential Revision: D77059596
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D77059596 |
xuhdev
added a commit
to xuhdev/redex
that referenced
this pull request
Jun 21, 2025
Summary: Rollback Plan: Differential Revision: D77059596
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D77059596 |
xuhdev
added a commit
to xuhdev/redex
that referenced
this pull request
Jun 21, 2025
Summary: Rollback Plan: Differential Revision: D77059596
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D77059596 |
xuhdev
added a commit
to xuhdev/redex
that referenced
this pull request
Jun 21, 2025
Summary: Rollback Plan: Differential Revision: D77059596
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D77059596 |
xuhdev
added a commit
to xuhdev/redex
that referenced
this pull request
Jun 21, 2025
Summary: Rollback Plan: Differential Revision: D77059596
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D77059596 |
xuhdev
added a commit
to xuhdev/redex
that referenced
this pull request
Jun 21, 2025
…acebook#943) Summary: This makes all supported distros being tested. Differential Revision: D77059596
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D77059596 |
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D77059596 |
xuhdev
added a commit
to xuhdev/redex
that referenced
this pull request
Jun 21, 2025
…acebook#943) Summary: This makes all supported distros being tested. Increased java target version to 8, which because 1.7 is no longer supported by the JDK version (21) in Ubuntu 24.04: ``` javac -source 1.7 -target 1.7 -cp build -d build -sourcepath java java/com/facebook/R.java warning: [options] bootstrap class path not set in conjunction with -source 7 error: Source option 7 is no longer supported. Use 8 or later. error: Target option 7 is no longer supported. Use 8 or later. ``` Differential Revision: D77059596
xuhdev
added a commit
to xuhdev/redex
that referenced
this pull request
Jun 21, 2025
…acebook#943) Summary: This makes all supported distros being tested. Increased java target version to 8, which because 1.7 is no longer supported by the JDK version (21) in Ubuntu 24.04: ``` javac -source 1.7 -target 1.7 -cp build -d build -sourcepath java java/com/facebook/R.java warning: [options] bootstrap class path not set in conjunction with -source 7 error: Source option 7 is no longer supported. Use 8 or later. error: Target option 7 is no longer supported. Use 8 or later. ``` Differential Revision: D77059596
xuhdev
added a commit
to xuhdev/redex
that referenced
this pull request
Jun 21, 2025
…acebook#943) Summary: This makes all supported distros being tested. Increased java target version to 8, which because 1.7 is no longer supported by the JDK version (21) in Ubuntu 24.04: ``` javac -source 1.7 -target 1.7 -cp build -d build -sourcepath java java/com/facebook/R.java warning: [options] bootstrap class path not set in conjunction with -source 7 error: Source option 7 is no longer supported. Use 8 or later. error: Target option 7 is no longer supported. Use 8 or later. ``` Differential Revision: D77059596
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D77059596 |
xuhdev
added a commit
to xuhdev/redex
that referenced
this pull request
Jun 21, 2025
…acebook#943) Summary: This makes all supported distros being tested. - Increased java target version to 8, which because 1.7 is no longer supported by the JDK version (21) in Ubuntu 24.04: ``` javac -source 1.7 -target 1.7 -cp build -d build -sourcepath java java/com/facebook/R.java warning: [options] bootstrap class path not set in conjunction with -source 7 error: Source option 7 is no longer supported. Use 8 or later. error: Target option 7 is no longer supported. Use 8 or later. ``` - Build GoogleTest with `-std=gnu++17` to enable string_view matchers, which is now being used by some tests. Differential Revision: D77059596
xuhdev
added a commit
to xuhdev/redex
that referenced
this pull request
Jun 21, 2025
…acebook#943) Summary: This makes all supported distros being tested. - Increased java target version to 8, which because 1.7 is no longer supported by the JDK version (21) in Ubuntu 24.04: ``` javac -source 1.7 -target 1.7 -cp build -d build -sourcepath java java/com/facebook/R.java warning: [options] bootstrap class path not set in conjunction with -source 7 error: Source option 7 is no longer supported. Use 8 or later. error: Target option 7 is no longer supported. Use 8 or later. ``` - Build GoogleTest with `-std=gnu++17` to enable string_view matchers, which is now being used by some tests. Differential Revision: D77059596
xuhdev
added a commit
to xuhdev/redex
that referenced
this pull request
Jun 21, 2025
…acebook#943) Summary: This makes all supported distros being tested. - Increased java target version to 8, which because 1.7 is no longer supported by the JDK version (21) in Ubuntu 24.04: ``` javac -source 1.7 -target 1.7 -cp build -d build -sourcepath java java/com/facebook/R.java warning: [options] bootstrap class path not set in conjunction with -source 7 error: Source option 7 is no longer supported. Use 8 or later. error: Target option 7 is no longer supported. Use 8 or later. ``` - Build GoogleTest with `-std=gnu++17` to enable string_view matchers, which is now being used by some tests. Differential Revision: D77059596
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D77059596 |
xuhdev
added a commit
to xuhdev/redex
that referenced
this pull request
Jun 21, 2025
…acebook#943) Summary: This makes all supported distros being tested. - Stick to JDK 17 in Ubuntu 24.04, because Ubuntu 24.04 defaults to JDK 21, which requries source target 8, which fails some tests. (We don't yet support JDK 21) - Build GoogleTest with `-std=gnu++17` to enable string_view matchers, which is now being used by some tests. Differential Revision: D77059596
xuhdev
added a commit
to xuhdev/redex
that referenced
this pull request
Jun 21, 2025
…acebook#943) Summary: This makes all supported distros being tested. - Stick to JDK 17 in Ubuntu 24.04, because Ubuntu 24.04 defaults to JDK 21, which requries source target 8, which fails some tests. (We don't yet support JDK 21) - Build GoogleTest with `-std=gnu++17` to enable string_view matchers, which is now being used by some tests. Differential Revision: D77059596
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D77059596 |
xuhdev
added a commit
to xuhdev/redex
that referenced
this pull request
Jun 21, 2025
…acebook#943) Summary: This makes all supported distros being tested. - Stick to JDK 17 in Ubuntu 24.04, because Ubuntu 24.04 defaults to JDK 21, which requries source target 8, which fails some tests. (We don't yet support JDK 21) - Build GoogleTest with `-std=gnu++17` to enable string_view matchers, which is now being used by some tests. Differential Revision: D77059596
Summary: `install_googletest_from_source` runs `pushd` twice. Differential Revision: D77061401
Summary: The `has_*` functions are incompatible with protobuf 3.12.4, which we support. We have lost coverage over this protobuf version last month and thus did not catch this. Differential Revision: D77064095
…acebook#943) Summary: This makes all supported distros being tested. - Stick to JDK 17 in Ubuntu 24.04, because Ubuntu 24.04 defaults to JDK 21, which requries source target 8, which fails some tests. (We don't yet support JDK 21) - Build GoogleTest with `-std=gnu++17` to enable string_view matchers, which is now being used by some tests. Differential Revision: D77059596
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D77059596 |
xuhdev
added a commit
to xuhdev/redex
that referenced
this pull request
Jun 21, 2025
…acebook#943) Summary: This makes all supported distros being tested. - Stick to JDK 17 in Ubuntu 24.04, because Ubuntu 24.04 defaults to JDK 21, which requries source target 8, which fails some tests. (We don't yet support JDK 21) - Build GoogleTest with `-std=gnu++17` to enable string_view matchers, which is now being used by some tests. Differential Revision: D77059596
xuhdev
added a commit
to xuhdev/redex
that referenced
this pull request
Jun 21, 2025
…acebook#943) Summary: This makes all supported distros being tested. - Stick to JDK 17 in Ubuntu 24.04, because Ubuntu 24.04 defaults to JDK 21, which requries source target 8, which fails some tests. (We don't yet support JDK 21) - Build GoogleTest with `-std=gnu++17` to enable string_view matchers, which is now being used by some tests. Differential Revision: D77059596
xuhdev
added a commit
to xuhdev/redex
that referenced
this pull request
Jun 21, 2025
…acebook#943) Summary: This makes all supported distros being tested. - Stick to JDK 17 in Ubuntu 24.04, because Ubuntu 24.04 defaults to JDK 21, which requries source target 8, which fails some tests. (We don't yet support JDK 21) - Build GoogleTest with `-std=gnu++17` to make sure `string_view` matchers are enabled on older versions of GCC. These matchers are now being used by some tests. Differential Revision: D77059596
xuhdev
added a commit
to xuhdev/redex
that referenced
this pull request
Jun 21, 2025
…acebook#943) Summary: This makes all supported distros being tested. - Stick to JDK 17 in Ubuntu 24.04, because Ubuntu 24.04 defaults to JDK 21, which requries source target 8, which fails some tests. (We don't yet support JDK 21) - Build GoogleTest with `-std=gnu++17` to make sure `string_view` matchers are enabled on older versions of GCC. These matchers are now being used by some tests. Differential Revision: D77059596
Contributor
|
This pull request has been merged in 1dbf52f. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Differential Revision: D77059596