use brew for macOS github actions#107
Closed
ahornby wants to merge 1 commit into
Closed
Conversation
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D34117005 |
ahornby
added a commit
to ahornby/sapling
that referenced
this pull request
Feb 10, 2022
Summary: Pull Request resolved: facebook#107 Speed up the mac builds on github actions by using brew for system dependencies Differential Revision: D34117005 fbshipit-source-id: b811ada0a0bd27557759ed2966ed32de800f7cee
ahornby
force-pushed
the
export-D34117005
branch
from
d632535 to
1b180a0
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D34117005 |
ahornby
added a commit
to ahornby/sapling
that referenced
this pull request
Feb 10, 2022
Summary: Pull Request resolved: facebook#107 Speed up the mac builds on github actions by using brew for system dependencies Differential Revision: D34117005 fbshipit-source-id: 730bbc3f1246c5c98061abc8e21373f49a6be04b
ahornby
force-pushed
the
export-D34117005
branch
from
1b180a0 to
d2f311c
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D34117005 |
ahornby
added a commit
to ahornby/sapling
that referenced
this pull request
Feb 10, 2022
Summary: Pull Request resolved: facebook#107 Speed up the mac builds on github actions by using brew for system dependencies Differential Revision: D34117005 fbshipit-source-id: c51e005563db3df3f6694eb90b69bc2e186cf6b9
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D34117005 |
ahornby
force-pushed
the
export-D34117005
branch
from
d2f311c to
9472d7e
Compare
Summary: Pull Request resolved: facebook#107 Speed up the mac builds on github actions by using brew for system dependencies To make this work had to fix some path ordering issues with install directories and homebrew. Namely: * Homebrew packages may not be on system paths, therefore we need to add them * Installed packages were being added after system paths, so our own installed thing might be ignored. On github these meant system python 3.9 was being used for hg tests rather than our specified v 3.8. We have some test fails on 3.9 with "SystemError: deallocated bytearray object has exported buffers", that are beyond the scope of this diff to fix! Differential Revision: D34117005 fbshipit-source-id: 03287f7a08f199c220e786ebaac75ccc99442ef2
ahornby
force-pushed
the
export-D34117005
branch
from
9472d7e to
5111a4e
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D34117005 |
ahornby
added a commit
to ahornby/sapling
that referenced
this pull request
Feb 12, 2022
…cebook#106) Summary: Pull Request resolved: facebook#106 Pull Request resolved: facebook#107 Summary * Add EdenFS builds on external CI now EdenSCM is good * Speed up the mac builds on github actions by using brew for system dependencies To make this work had to fix some path ordering issues with install directories for Linux and Mac, and generalise the homebrew path fixups we were doing for bison to all the used homebrew packages. Previously Installed packages were being added after system paths, so our own installed thing might be ignored. On github these meant system python 3.9 was being used for hg tests rather than our specified 3.8 (this showed we have some test fails on python 3.9 with "SystemError: deallocated bytearray object has exported buffers", that are beyond the scope of this diff to fix) Also needed to include the getdeps generated python into the generated edenscmdeps3.zip archive setup.py produces otherwise EdenFS tests failed to import thrift.Thrift Reviewed By: chadaustin Differential Revision: D34116505 fbshipit-source-id: e2d749882ac9d711fbaf3652645f4cf6212e83da
ahornby
added a commit
to ahornby/sapling
that referenced
this pull request
Feb 12, 2022
…cebook#106) Summary: Pull Request resolved: facebook#106 Pull Request resolved: facebook#107 Summary * Add EdenFS builds on external CI now EdenSCM is good * Speed up the mac builds on github actions by using brew for system dependencies To make this work had to fix some path ordering issues with install directories for Linux and Mac, and generalise the homebrew path fixups we were doing for bison to all the used homebrew packages. Previously Installed packages were being added after system paths, so our own installed thing might be ignored. On github these meant system python 3.9 was being used for hg tests rather than our specified 3.8 (this showed we have some test fails on python 3.9 with "SystemError: deallocated bytearray object has exported buffers", that are beyond the scope of this diff to fix) Also needed to include the getdeps generated python into the generated edenscmdeps3.zip archive setup.py produces otherwise EdenFS tests failed to import thrift.Thrift Reviewed By: chadaustin Differential Revision: D34116505 fbshipit-source-id: 7519958711024023bb5ca47a00cda9b44d12353d
ahornby
added a commit
to ahornby/sapling
that referenced
this pull request
Feb 12, 2022
…cebook#106) Summary: Pull Request resolved: facebook#106 Pull Request resolved: facebook#107 Summary * Add EdenFS builds on external CI now EdenSCM is good * Speed up the mac builds on github actions by using brew for system dependencies To make this work had to fix some path ordering issues with install directories for Linux and Mac, and generalise the homebrew path fixups we were doing for bison to all the used homebrew packages. Previously Installed packages were being added after system paths, so our own installed thing might be ignored. On github these meant system python 3.9 was being used for hg tests rather than our specified 3.8 (this showed we have some test fails on python 3.9 with "SystemError: deallocated bytearray object has exported buffers", that are beyond the scope of this diff to fix) Also needed to include the getdeps generated python into the generated edenscmdeps3.zip archive setup.py produces otherwise EdenFS tests failed to import thrift.Thrift Reviewed By: chadaustin Differential Revision: D34116505 fbshipit-source-id: 3b2bdce11478b880936575cea51216fc69740d00
ahornby
added a commit
to ahornby/sapling
that referenced
this pull request
Feb 13, 2022
…cebook#106) Summary: Pull Request resolved: facebook#106 Pull Request resolved: facebook#107 Summary * Add EdenFS builds on external CI now EdenSCM is good * Speed up the mac builds on github actions by using brew for system dependencies To make this work had to fix some path ordering issues with install directories for Linux and Mac, and generalise the homebrew path fixups we were doing for bison to all the used homebrew packages. Previously Installed packages were being added after system paths, so our own installed thing might be ignored. On github these meant system python 3.9 was being used for hg tests rather than our specified 3.8 (this showed we have some test fails on python 3.9 with "SystemError: deallocated bytearray object has exported buffers", that are beyond the scope of this diff to fix) Also needed to include the getdeps generated python into the generated edenscmdeps3.zip archive setup.py produces otherwise EdenFS tests failed to import thrift.Thrift Reviewed By: chadaustin Differential Revision: D34116505 fbshipit-source-id: 3c2732a77fbf89af6a02904d887a818e6d6711a9
ahornby
added a commit
to ahornby/sapling
that referenced
this pull request
Feb 14, 2022
…cebook#106) Summary: Pull Request resolved: facebook#106 Pull Request resolved: facebook#107 Summary * Add EdenFS builds on external CI now EdenSCM is good * Speed up the mac builds on github actions by using brew for system dependencies To make this work had to fix some path ordering issues with install directories for Linux and Mac, and generalise the homebrew path fixups we were doing for bison to all the used homebrew packages. Previously Installed packages were being added after system paths, so our own installed thing might be ignored. On github these meant system python 3.9 was being used for hg tests rather than our specified 3.8 (this showed we have some test fails on python 3.9 with "SystemError: deallocated bytearray object has exported buffers", that are beyond the scope of this diff to fix) Also needed to include the getdeps generated python into the generated edenscmdeps3.zip archive setup.py produces otherwise EdenFS tests failed to import thrift.Thrift Reviewed By: chadaustin Differential Revision: D34116505 fbshipit-source-id: aeadcd5822772f32a2d6bd30dc047df3d468b59a
ahornby
added a commit
to ahornby/sapling
that referenced
this pull request
Feb 14, 2022
…cebook#106) Summary: Pull Request resolved: facebook#106 Pull Request resolved: facebook#107 Summary * Add EdenFS builds on external CI now EdenSCM is good * Mac builds on github actions by using brew for system dependencies To make this work had to fix some path ordering issues with install directories for Linux and Mac, and generalise the homebrew path fixups we were doing for bison to all the used homebrew packages. Previously Installed packages were being added after system paths, so our own installed thing might be ignored. On github these meant system python 3.9 was being used for hg tests rather than our specified 3.8 (this showed we have some test fails on python 3.9 with "SystemError: deallocated bytearray object has exported buffers", that are beyond the scope of this diff to fix) Also needed to include the getdeps generated python into the generated edenscmdeps3.zip archive setup.py produces otherwise EdenFS tests failed to import thrift.Thrift Eden tests are hanging when run externally about half way through, so disable them on github actions for now as this PR is already fairly large. They work when run locally on an internal devserver, so probably some bit of environment necessary is not defined in the test runner Reviewed By: chadaustin Differential Revision: D34116505 fbshipit-source-id: 876a65794bb742e4e7bf9b9c3743e30276689530
facebook-github-bot
pushed a commit
to facebook/openr
that referenced
this pull request
Feb 14, 2022
Summary: Pull Request resolved: facebook/sapling#106 Pull Request resolved: facebook/sapling#107 Summary * Add EdenFS builds on external CI now EdenSCM is good * Mac builds on github actions by using brew for system dependencies To make this work had to fix some path ordering issues with install directories for Linux and Mac, and generalise the homebrew path fixups we were doing for bison to all the used homebrew packages. Previously Installed packages were being added after system paths, so our own installed thing might be ignored. On github these meant system python 3.9 was being used for hg tests rather than our specified 3.8 (this showed we have some test fails on python 3.9 with "SystemError: deallocated bytearray object has exported buffers", that are beyond the scope of this diff to fix) Also needed to include the getdeps generated python into the generated edenscmdeps3.zip archive setup.py produces otherwise EdenFS tests failed to import thrift.Thrift Eden tests are hanging when run externally about half way through, so disable them on github actions for now as this PR is already fairly large. They work when run locally on an internal devserver, so probably some bit of environment necessary is not defined in the test runner Reviewed By: chadaustin Differential Revision: D34116505 fbshipit-source-id: d0d628db5daabc28d0bd8997cd5c1bc885ed1e73
facebook-github-bot
pushed a commit
to facebookarchive/fbzmq
that referenced
this pull request
Feb 14, 2022
Summary: Pull Request resolved: facebook/sapling#106 Pull Request resolved: facebook/sapling#107 Summary * Add EdenFS builds on external CI now EdenSCM is good * Mac builds on github actions by using brew for system dependencies To make this work had to fix some path ordering issues with install directories for Linux and Mac, and generalise the homebrew path fixups we were doing for bison to all the used homebrew packages. Previously Installed packages were being added after system paths, so our own installed thing might be ignored. On github these meant system python 3.9 was being used for hg tests rather than our specified 3.8 (this showed we have some test fails on python 3.9 with "SystemError: deallocated bytearray object has exported buffers", that are beyond the scope of this diff to fix) Also needed to include the getdeps generated python into the generated edenscmdeps3.zip archive setup.py produces otherwise EdenFS tests failed to import thrift.Thrift Eden tests are hanging when run externally about half way through, so disable them on github actions for now as this PR is already fairly large. They work when run locally on an internal devserver, so probably some bit of environment necessary is not defined in the test runner Reviewed By: chadaustin Differential Revision: D34116505 fbshipit-source-id: d0d628db5daabc28d0bd8997cd5c1bc885ed1e73
facebook-github-bot
pushed a commit
to facebook/fboss
that referenced
this pull request
Feb 14, 2022
Summary: Pull Request resolved: facebook/sapling#106 Pull Request resolved: facebook/sapling#107 Summary * Add EdenFS builds on external CI now EdenSCM is good * Mac builds on github actions by using brew for system dependencies To make this work had to fix some path ordering issues with install directories for Linux and Mac, and generalise the homebrew path fixups we were doing for bison to all the used homebrew packages. Previously Installed packages were being added after system paths, so our own installed thing might be ignored. On github these meant system python 3.9 was being used for hg tests rather than our specified 3.8 (this showed we have some test fails on python 3.9 with "SystemError: deallocated bytearray object has exported buffers", that are beyond the scope of this diff to fix) Also needed to include the getdeps generated python into the generated edenscmdeps3.zip archive setup.py produces otherwise EdenFS tests failed to import thrift.Thrift Eden tests are hanging when run externally about half way through, so disable them on github actions for now as this PR is already fairly large. They work when run locally on an internal devserver, so probably some bit of environment necessary is not defined in the test runner Reviewed By: chadaustin Differential Revision: D34116505 fbshipit-source-id: d0d628db5daabc28d0bd8997cd5c1bc885ed1e73
facebook-github-bot
pushed a commit
to facebook/proxygen
that referenced
this pull request
Feb 14, 2022
Summary: Pull Request resolved: facebook/sapling#106 Pull Request resolved: facebook/sapling#107 Summary * Add EdenFS builds on external CI now EdenSCM is good * Mac builds on github actions by using brew for system dependencies To make this work had to fix some path ordering issues with install directories for Linux and Mac, and generalise the homebrew path fixups we were doing for bison to all the used homebrew packages. Previously Installed packages were being added after system paths, so our own installed thing might be ignored. On github these meant system python 3.9 was being used for hg tests rather than our specified 3.8 (this showed we have some test fails on python 3.9 with "SystemError: deallocated bytearray object has exported buffers", that are beyond the scope of this diff to fix) Also needed to include the getdeps generated python into the generated edenscmdeps3.zip archive setup.py produces otherwise EdenFS tests failed to import thrift.Thrift Eden tests are hanging when run externally about half way through, so disable them on github actions for now as this PR is already fairly large. They work when run locally on an internal devserver, so probably some bit of environment necessary is not defined in the test runner Reviewed By: chadaustin Differential Revision: D34116505 fbshipit-source-id: d0d628db5daabc28d0bd8997cd5c1bc885ed1e73
facebook-github-bot
pushed a commit
to facebook/wangle
that referenced
this pull request
Feb 14, 2022
Summary: Pull Request resolved: facebook/sapling#106 Pull Request resolved: facebook/sapling#107 Summary * Add EdenFS builds on external CI now EdenSCM is good * Mac builds on github actions by using brew for system dependencies To make this work had to fix some path ordering issues with install directories for Linux and Mac, and generalise the homebrew path fixups we were doing for bison to all the used homebrew packages. Previously Installed packages were being added after system paths, so our own installed thing might be ignored. On github these meant system python 3.9 was being used for hg tests rather than our specified 3.8 (this showed we have some test fails on python 3.9 with "SystemError: deallocated bytearray object has exported buffers", that are beyond the scope of this diff to fix) Also needed to include the getdeps generated python into the generated edenscmdeps3.zip archive setup.py produces otherwise EdenFS tests failed to import thrift.Thrift Eden tests are hanging when run externally about half way through, so disable them on github actions for now as this PR is already fairly large. They work when run locally on an internal devserver, so probably some bit of environment necessary is not defined in the test runner Reviewed By: chadaustin Differential Revision: D34116505 fbshipit-source-id: d0d628db5daabc28d0bd8997cd5c1bc885ed1e73
facebook-github-bot
pushed a commit
to facebook/mvfst
that referenced
this pull request
Feb 14, 2022
Summary: Pull Request resolved: facebook/sapling#106 Pull Request resolved: facebook/sapling#107 Summary * Add EdenFS builds on external CI now EdenSCM is good * Mac builds on github actions by using brew for system dependencies To make this work had to fix some path ordering issues with install directories for Linux and Mac, and generalise the homebrew path fixups we were doing for bison to all the used homebrew packages. Previously Installed packages were being added after system paths, so our own installed thing might be ignored. On github these meant system python 3.9 was being used for hg tests rather than our specified 3.8 (this showed we have some test fails on python 3.9 with "SystemError: deallocated bytearray object has exported buffers", that are beyond the scope of this diff to fix) Also needed to include the getdeps generated python into the generated edenscmdeps3.zip archive setup.py produces otherwise EdenFS tests failed to import thrift.Thrift Eden tests are hanging when run externally about half way through, so disable them on github actions for now as this PR is already fairly large. They work when run locally on an internal devserver, so probably some bit of environment necessary is not defined in the test runner Reviewed By: chadaustin Differential Revision: D34116505 fbshipit-source-id: d0d628db5daabc28d0bd8997cd5c1bc885ed1e73
facebook-github-bot
pushed a commit
to facebook/watchman
that referenced
this pull request
Feb 14, 2022
Summary: Pull Request resolved: facebook/sapling#106 Pull Request resolved: facebook/sapling#107 Summary * Add EdenFS builds on external CI now EdenSCM is good * Mac builds on github actions by using brew for system dependencies To make this work had to fix some path ordering issues with install directories for Linux and Mac, and generalise the homebrew path fixups we were doing for bison to all the used homebrew packages. Previously Installed packages were being added after system paths, so our own installed thing might be ignored. On github these meant system python 3.9 was being used for hg tests rather than our specified 3.8 (this showed we have some test fails on python 3.9 with "SystemError: deallocated bytearray object has exported buffers", that are beyond the scope of this diff to fix) Also needed to include the getdeps generated python into the generated edenscmdeps3.zip archive setup.py produces otherwise EdenFS tests failed to import thrift.Thrift Eden tests are hanging when run externally about half way through, so disable them on github actions for now as this PR is already fairly large. They work when run locally on an internal devserver, so probably some bit of environment necessary is not defined in the test runner Reviewed By: chadaustin Differential Revision: D34116505 fbshipit-source-id: d0d628db5daabc28d0bd8997cd5c1bc885ed1e73
facebook-github-bot
pushed a commit
to facebookincubator/katran
that referenced
this pull request
Feb 14, 2022
Summary: Pull Request resolved: facebook/sapling#106 Pull Request resolved: facebook/sapling#107 Summary * Add EdenFS builds on external CI now EdenSCM is good * Mac builds on github actions by using brew for system dependencies To make this work had to fix some path ordering issues with install directories for Linux and Mac, and generalise the homebrew path fixups we were doing for bison to all the used homebrew packages. Previously Installed packages were being added after system paths, so our own installed thing might be ignored. On github these meant system python 3.9 was being used for hg tests rather than our specified 3.8 (this showed we have some test fails on python 3.9 with "SystemError: deallocated bytearray object has exported buffers", that are beyond the scope of this diff to fix) Also needed to include the getdeps generated python into the generated edenscmdeps3.zip archive setup.py produces otherwise EdenFS tests failed to import thrift.Thrift Eden tests are hanging when run externally about half way through, so disable them on github actions for now as this PR is already fairly large. They work when run locally on an internal devserver, so probably some bit of environment necessary is not defined in the test runner Reviewed By: chadaustin Differential Revision: D34116505 fbshipit-source-id: d0d628db5daabc28d0bd8997cd5c1bc885ed1e73
facebook-github-bot
pushed a commit
to facebook/fb303
that referenced
this pull request
Feb 14, 2022
Summary: Pull Request resolved: facebook/sapling#106 Pull Request resolved: facebook/sapling#107 Summary * Add EdenFS builds on external CI now EdenSCM is good * Mac builds on github actions by using brew for system dependencies To make this work had to fix some path ordering issues with install directories for Linux and Mac, and generalise the homebrew path fixups we were doing for bison to all the used homebrew packages. Previously Installed packages were being added after system paths, so our own installed thing might be ignored. On github these meant system python 3.9 was being used for hg tests rather than our specified 3.8 (this showed we have some test fails on python 3.9 with "SystemError: deallocated bytearray object has exported buffers", that are beyond the scope of this diff to fix) Also needed to include the getdeps generated python into the generated edenscmdeps3.zip archive setup.py produces otherwise EdenFS tests failed to import thrift.Thrift Eden tests are hanging when run externally about half way through, so disable them on github actions for now as this PR is already fairly large. They work when run locally on an internal devserver, so probably some bit of environment necessary is not defined in the test runner Reviewed By: chadaustin Differential Revision: D34116505 fbshipit-source-id: d0d628db5daabc28d0bd8997cd5c1bc885ed1e73
facebook-github-bot
pushed a commit
to facebookincubator/reindeer
that referenced
this pull request
Feb 14, 2022
Summary: Pull Request resolved: facebook/sapling#106 Pull Request resolved: facebook/sapling#107 Summary * Add EdenFS builds on external CI now EdenSCM is good * Mac builds on github actions by using brew for system dependencies To make this work had to fix some path ordering issues with install directories for Linux and Mac, and generalise the homebrew path fixups we were doing for bison to all the used homebrew packages. Previously Installed packages were being added after system paths, so our own installed thing might be ignored. On github these meant system python 3.9 was being used for hg tests rather than our specified 3.8 (this showed we have some test fails on python 3.9 with "SystemError: deallocated bytearray object has exported buffers", that are beyond the scope of this diff to fix) Also needed to include the getdeps generated python into the generated edenscmdeps3.zip archive setup.py produces otherwise EdenFS tests failed to import thrift.Thrift Eden tests are hanging when run externally about half way through, so disable them on github actions for now as this PR is already fairly large. They work when run locally on an internal devserver, so probably some bit of environment necessary is not defined in the test runner Reviewed By: chadaustin Differential Revision: D34116505 fbshipit-source-id: d0d628db5daabc28d0bd8997cd5c1bc885ed1e73
facebook-github-bot
pushed a commit
that referenced
this pull request
Feb 14, 2022
Summary: Pull Request resolved: #106 Pull Request resolved: #107 Summary * Add EdenFS builds on external CI now EdenSCM is good * Mac builds on github actions by using brew for system dependencies To make this work had to fix some path ordering issues with install directories for Linux and Mac, and generalise the homebrew path fixups we were doing for bison to all the used homebrew packages. Previously Installed packages were being added after system paths, so our own installed thing might be ignored. On github these meant system python 3.9 was being used for hg tests rather than our specified 3.8 (this showed we have some test fails on python 3.9 with "SystemError: deallocated bytearray object has exported buffers", that are beyond the scope of this diff to fix) Also needed to include the getdeps generated python into the generated edenscmdeps3.zip archive setup.py produces otherwise EdenFS tests failed to import thrift.Thrift Eden tests are hanging when run externally about half way through, so disable them on github actions for now as this PR is already fairly large. They work when run locally on an internal devserver, so probably some bit of environment necessary is not defined in the test runner Reviewed By: chadaustin Differential Revision: D34116505 fbshipit-source-id: d0d628db5daabc28d0bd8997cd5c1bc885ed1e73
facebook-github-bot
pushed a commit
to facebookincubator/fizz
that referenced
this pull request
Feb 14, 2022
Summary: Pull Request resolved: facebook/sapling#106 Pull Request resolved: facebook/sapling#107 Summary * Add EdenFS builds on external CI now EdenSCM is good * Mac builds on github actions by using brew for system dependencies To make this work had to fix some path ordering issues with install directories for Linux and Mac, and generalise the homebrew path fixups we were doing for bison to all the used homebrew packages. Previously Installed packages were being added after system paths, so our own installed thing might be ignored. On github these meant system python 3.9 was being used for hg tests rather than our specified 3.8 (this showed we have some test fails on python 3.9 with "SystemError: deallocated bytearray object has exported buffers", that are beyond the scope of this diff to fix) Also needed to include the getdeps generated python into the generated edenscmdeps3.zip archive setup.py produces otherwise EdenFS tests failed to import thrift.Thrift Eden tests are hanging when run externally about half way through, so disable them on github actions for now as this PR is already fairly large. They work when run locally on an internal devserver, so probably some bit of environment necessary is not defined in the test runner Reviewed By: chadaustin Differential Revision: D34116505 fbshipit-source-id: d0d628db5daabc28d0bd8997cd5c1bc885ed1e73
facebook-github-bot
pushed a commit
to facebook/folly
that referenced
this pull request
Feb 14, 2022
Summary: Pull Request resolved: facebook/sapling#106 Pull Request resolved: facebook/sapling#107 Summary * Add EdenFS builds on external CI now EdenSCM is good * Mac builds on github actions by using brew for system dependencies To make this work had to fix some path ordering issues with install directories for Linux and Mac, and generalise the homebrew path fixups we were doing for bison to all the used homebrew packages. Previously Installed packages were being added after system paths, so our own installed thing might be ignored. On github these meant system python 3.9 was being used for hg tests rather than our specified 3.8 (this showed we have some test fails on python 3.9 with "SystemError: deallocated bytearray object has exported buffers", that are beyond the scope of this diff to fix) Also needed to include the getdeps generated python into the generated edenscmdeps3.zip archive setup.py produces otherwise EdenFS tests failed to import thrift.Thrift Eden tests are hanging when run externally about half way through, so disable them on github actions for now as this PR is already fairly large. They work when run locally on an internal devserver, so probably some bit of environment necessary is not defined in the test runner Reviewed By: chadaustin Differential Revision: D34116505 fbshipit-source-id: d0d628db5daabc28d0bd8997cd5c1bc885ed1e73
facebook-github-bot
pushed a commit
to facebook/fbthrift
that referenced
this pull request
Feb 14, 2022
Summary: Pull Request resolved: facebook/sapling#106 Pull Request resolved: facebook/sapling#107 Summary * Add EdenFS builds on external CI now EdenSCM is good * Mac builds on github actions by using brew for system dependencies To make this work had to fix some path ordering issues with install directories for Linux and Mac, and generalise the homebrew path fixups we were doing for bison to all the used homebrew packages. Previously Installed packages were being added after system paths, so our own installed thing might be ignored. On github these meant system python 3.9 was being used for hg tests rather than our specified 3.8 (this showed we have some test fails on python 3.9 with "SystemError: deallocated bytearray object has exported buffers", that are beyond the scope of this diff to fix) Also needed to include the getdeps generated python into the generated edenscmdeps3.zip archive setup.py produces otherwise EdenFS tests failed to import thrift.Thrift Eden tests are hanging when run externally about half way through, so disable them on github actions for now as this PR is already fairly large. They work when run locally on an internal devserver, so probably some bit of environment necessary is not defined in the test runner Reviewed By: chadaustin Differential Revision: D34116505 fbshipit-source-id: d0d628db5daabc28d0bd8997cd5c1bc885ed1e73
facebook-github-bot
pushed a commit
to facebookexperimental/rust-shed
that referenced
this pull request
Feb 14, 2022
Summary: Pull Request resolved: facebook/sapling#106 Pull Request resolved: facebook/sapling#107 Summary * Add EdenFS builds on external CI now EdenSCM is good * Mac builds on github actions by using brew for system dependencies To make this work had to fix some path ordering issues with install directories for Linux and Mac, and generalise the homebrew path fixups we were doing for bison to all the used homebrew packages. Previously Installed packages were being added after system paths, so our own installed thing might be ignored. On github these meant system python 3.9 was being used for hg tests rather than our specified 3.8 (this showed we have some test fails on python 3.9 with "SystemError: deallocated bytearray object has exported buffers", that are beyond the scope of this diff to fix) Also needed to include the getdeps generated python into the generated edenscmdeps3.zip archive setup.py produces otherwise EdenFS tests failed to import thrift.Thrift Eden tests are hanging when run externally about half way through, so disable them on github actions for now as this PR is already fairly large. They work when run locally on an internal devserver, so probably some bit of environment necessary is not defined in the test runner Reviewed By: chadaustin Differential Revision: D34116505 fbshipit-source-id: d0d628db5daabc28d0bd8997cd5c1bc885ed1e73
facebook-github-bot
pushed a commit
to facebookincubator/velox
that referenced
this pull request
Feb 14, 2022
Summary: Pull Request resolved: facebook/sapling#106 Pull Request resolved: facebook/sapling#107 Summary * Add EdenFS builds on external CI now EdenSCM is good * Mac builds on github actions by using brew for system dependencies To make this work had to fix some path ordering issues with install directories for Linux and Mac, and generalise the homebrew path fixups we were doing for bison to all the used homebrew packages. Previously Installed packages were being added after system paths, so our own installed thing might be ignored. On github these meant system python 3.9 was being used for hg tests rather than our specified 3.8 (this showed we have some test fails on python 3.9 with "SystemError: deallocated bytearray object has exported buffers", that are beyond the scope of this diff to fix) Also needed to include the getdeps generated python into the generated edenscmdeps3.zip archive setup.py produces otherwise EdenFS tests failed to import thrift.Thrift Eden tests are hanging when run externally about half way through, so disable them on github actions for now as this PR is already fairly large. They work when run locally on an internal devserver, so probably some bit of environment necessary is not defined in the test runner Reviewed By: chadaustin Differential Revision: D34116505 fbshipit-source-id: d0d628db5daabc28d0bd8997cd5c1bc885ed1e73
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary: Speed up the mac builds on github actions by using brew for system dependencies
Differential Revision: D34117005