fix(fbcode_builder): Fixes to fbcode_builder needed by sapling/edenfs build#1126
Closed
ben-- wants to merge 3 commits intofacebook:mainfrom
Closed
fix(fbcode_builder): Fixes to fbcode_builder needed by sapling/edenfs build#1126ben-- wants to merge 3 commits intofacebook:mainfrom
ben-- wants to merge 3 commits intofacebook:mainfrom
Conversation
Contributor
|
@facebook-github-bot has imported this pull request. If you are a Meta employee, you can view this in D83007559. (Because this pull request was imported automatically, there will not be any future comments.) |
ben--
changed the title
meta-codesync bot
pushed a commit
to facebook/fboss
that referenced
this pull request
Oct 13, 2025
Summary: Three independent changes: 1. Fix merge damage in FBPythonBinary.cmake 2. Define `fbcode_build=False` in rust builds to eliminate errors/warnings 3. Add a missing dependency to zstd Tested by building sapling using the GitHub action (won't run fully until other PRs land): ``` act --container-architecture linux/x86_64 -W .github/workflows/edenfs_linux.yml ``` X-link: facebook/sapling#1126 Differential Revision: D83007559 fbshipit-source-id: e44a3f8eed4cf032c3ad33b8dc306eb589901842
meta-codesync bot
pushed a commit
to facebook/proxygen
that referenced
this pull request
Oct 13, 2025
Summary: Three independent changes: 1. Fix merge damage in FBPythonBinary.cmake 2. Define `fbcode_build=False` in rust builds to eliminate errors/warnings 3. Add a missing dependency to zstd Tested by building sapling using the GitHub action (won't run fully until other PRs land): ``` act --container-architecture linux/x86_64 -W .github/workflows/edenfs_linux.yml ``` X-link: facebook/sapling#1126 Differential Revision: D83007559 fbshipit-source-id: e44a3f8eed4cf032c3ad33b8dc306eb589901842
meta-codesync bot
pushed a commit
to facebook/mvfst
that referenced
this pull request
Oct 13, 2025
Summary: Three independent changes: 1. Fix merge damage in FBPythonBinary.cmake 2. Define `fbcode_build=False` in rust builds to eliminate errors/warnings 3. Add a missing dependency to zstd Tested by building sapling using the GitHub action (won't run fully until other PRs land): ``` act --container-architecture linux/x86_64 -W .github/workflows/edenfs_linux.yml ``` X-link: facebook/sapling#1126 Differential Revision: D83007559 fbshipit-source-id: e44a3f8eed4cf032c3ad33b8dc306eb589901842
meta-codesync bot
pushed a commit
to facebook/fbthrift
that referenced
this pull request
Oct 13, 2025
Summary: Three independent changes: 1. Fix merge damage in FBPythonBinary.cmake 2. Define `fbcode_build=False` in rust builds to eliminate errors/warnings 3. Add a missing dependency to zstd Tested by building sapling using the GitHub action (won't run fully until other PRs land): ``` act --container-architecture linux/x86_64 -W .github/workflows/edenfs_linux.yml ``` X-link: facebook/sapling#1126 Differential Revision: D83007559 fbshipit-source-id: e44a3f8eed4cf032c3ad33b8dc306eb589901842
meta-codesync bot
pushed a commit
to facebookexperimental/rust-shed
that referenced
this pull request
Oct 13, 2025
Summary: Three independent changes: 1. Fix merge damage in FBPythonBinary.cmake 2. Define `fbcode_build=False` in rust builds to eliminate errors/warnings 3. Add a missing dependency to zstd Tested by building sapling using the GitHub action (won't run fully until other PRs land): ``` act --container-architecture linux/x86_64 -W .github/workflows/edenfs_linux.yml ``` X-link: facebook/sapling#1126 Differential Revision: D83007559 fbshipit-source-id: e44a3f8eed4cf032c3ad33b8dc306eb589901842
meta-codesync bot
pushed a commit
to facebookexperimental/moxygen
that referenced
this pull request
Oct 13, 2025
Summary: Three independent changes: 1. Fix merge damage in FBPythonBinary.cmake 2. Define `fbcode_build=False` in rust builds to eliminate errors/warnings 3. Add a missing dependency to zstd Tested by building sapling using the GitHub action (won't run fully until other PRs land): ``` act --container-architecture linux/x86_64 -W .github/workflows/edenfs_linux.yml ``` X-link: facebook/sapling#1126 Differential Revision: D83007559 fbshipit-source-id: e44a3f8eed4cf032c3ad33b8dc306eb589901842
meta-codesync bot
pushed a commit
to facebookincubator/hsthrift
that referenced
this pull request
Oct 13, 2025
Summary: Three independent changes: 1. Fix merge damage in FBPythonBinary.cmake 2. Define `fbcode_build=False` in rust builds to eliminate errors/warnings 3. Add a missing dependency to zstd Tested by building sapling using the GitHub action (won't run fully until other PRs land): ``` act --container-architecture linux/x86_64 -W .github/workflows/edenfs_linux.yml ``` X-link: facebook/sapling#1126 Differential Revision: D83007559 fbshipit-source-id: e44a3f8eed4cf032c3ad33b8dc306eb589901842
meta-codesync bot
pushed a commit
to facebook/watchman
that referenced
this pull request
Oct 13, 2025
Summary: Three independent changes: 1. Fix merge damage in FBPythonBinary.cmake 2. Define `fbcode_build=False` in rust builds to eliminate errors/warnings 3. Add a missing dependency to zstd Tested by building sapling using the GitHub action (won't run fully until other PRs land): ``` act --container-architecture linux/x86_64 -W .github/workflows/edenfs_linux.yml ``` X-link: facebook/sapling#1126 Differential Revision: D83007559 fbshipit-source-id: e44a3f8eed4cf032c3ad33b8dc306eb589901842
meta-codesync bot
pushed a commit
to facebookincubator/fizz
that referenced
this pull request
Oct 13, 2025
Summary: Three independent changes: 1. Fix merge damage in FBPythonBinary.cmake 2. Define `fbcode_build=False` in rust builds to eliminate errors/warnings 3. Add a missing dependency to zstd Tested by building sapling using the GitHub action (won't run fully until other PRs land): ``` act --container-architecture linux/x86_64 -W .github/workflows/edenfs_linux.yml ``` X-link: facebook/sapling#1126 Differential Revision: D83007559 fbshipit-source-id: e44a3f8eed4cf032c3ad33b8dc306eb589901842
|
This pull request has been merged in e0e866c. |
meta-codesync bot
pushed a commit
to facebook/hhvm
that referenced
this pull request
Oct 13, 2025
Summary: Three independent changes: 1. Fix merge damage in FBPythonBinary.cmake 2. Define `fbcode_build=False` in rust builds to eliminate errors/warnings 3. Add a missing dependency to zstd Tested by building sapling using the GitHub action (won't run fully until other PRs land): ``` act --container-architecture linux/x86_64 -W .github/workflows/edenfs_linux.yml ``` X-link: facebook/sapling#1126 Differential Revision: D83007559 fbshipit-source-id: e44a3f8eed4cf032c3ad33b8dc306eb589901842
meta-codesync bot
pushed a commit
to facebook/folly
that referenced
this pull request
Oct 13, 2025
Summary: Three independent changes: 1. Fix merge damage in FBPythonBinary.cmake 2. Define `fbcode_build=False` in rust builds to eliminate errors/warnings 3. Add a missing dependency to zstd Tested by building sapling using the GitHub action (won't run fully until other PRs land): ``` act --container-architecture linux/x86_64 -W .github/workflows/edenfs_linux.yml ``` X-link: facebook/sapling#1126 Differential Revision: D83007559 fbshipit-source-id: e44a3f8eed4cf032c3ad33b8dc306eb589901842
meta-codesync bot
pushed a commit
to facebook/fb303
that referenced
this pull request
Oct 13, 2025
Summary: Three independent changes: 1. Fix merge damage in FBPythonBinary.cmake 2. Define `fbcode_build=False` in rust builds to eliminate errors/warnings 3. Add a missing dependency to zstd Tested by building sapling using the GitHub action (won't run fully until other PRs land): ``` act --container-architecture linux/x86_64 -W .github/workflows/edenfs_linux.yml ``` X-link: facebook/sapling#1126 Differential Revision: D83007559 fbshipit-source-id: e44a3f8eed4cf032c3ad33b8dc306eb589901842
meta-codesync bot
pushed a commit
to facebookexperimental/edencommon
that referenced
this pull request
Oct 13, 2025
Summary: Three independent changes: 1. Fix merge damage in FBPythonBinary.cmake 2. Define `fbcode_build=False` in rust builds to eliminate errors/warnings 3. Add a missing dependency to zstd Tested by building sapling using the GitHub action (won't run fully until other PRs land): ``` act --container-architecture linux/x86_64 -W .github/workflows/edenfs_linux.yml ``` X-link: facebook/sapling#1126 Differential Revision: D83007559 fbshipit-source-id: e44a3f8eed4cf032c3ad33b8dc306eb589901842
meta-codesync bot
pushed a commit
to facebook/openr
that referenced
this pull request
Oct 13, 2025
Summary: Three independent changes: 1. Fix merge damage in FBPythonBinary.cmake 2. Define `fbcode_build=False` in rust builds to eliminate errors/warnings 3. Add a missing dependency to zstd Tested by building sapling using the GitHub action (won't run fully until other PRs land): ``` act --container-architecture linux/x86_64 -W .github/workflows/edenfs_linux.yml ``` X-link: facebook/sapling#1126 Differential Revision: D83007559 fbshipit-source-id: e44a3f8eed4cf032c3ad33b8dc306eb589901842
meta-codesync bot
pushed a commit
to facebook/CacheLib
that referenced
this pull request
Oct 13, 2025
Summary: Three independent changes: 1. Fix merge damage in FBPythonBinary.cmake 2. Define `fbcode_build=False` in rust builds to eliminate errors/warnings 3. Add a missing dependency to zstd Tested by building sapling using the GitHub action (won't run fully until other PRs land): ``` act --container-architecture linux/x86_64 -W .github/workflows/edenfs_linux.yml ``` X-link: facebook/sapling#1126 Differential Revision: D83007559 fbshipit-source-id: e44a3f8eed4cf032c3ad33b8dc306eb589901842
meta-codesync bot
pushed a commit
to facebook/wangle
that referenced
this pull request
Oct 13, 2025
Summary: Three independent changes: 1. Fix merge damage in FBPythonBinary.cmake 2. Define `fbcode_build=False` in rust builds to eliminate errors/warnings 3. Add a missing dependency to zstd Tested by building sapling using the GitHub action (won't run fully until other PRs land): ``` act --container-architecture linux/x86_64 -W .github/workflows/edenfs_linux.yml ``` X-link: facebook/sapling#1126 Differential Revision: D83007559 fbshipit-source-id: e44a3f8eed4cf032c3ad33b8dc306eb589901842
meta-codesync bot
pushed a commit
to facebookincubator/cinderx
that referenced
this pull request
Oct 13, 2025
Summary: Three independent changes: 1. Fix merge damage in FBPythonBinary.cmake 2. Define `fbcode_build=False` in rust builds to eliminate errors/warnings 3. Add a missing dependency to zstd Tested by building sapling using the GitHub action (won't run fully until other PRs land): ``` act --container-architecture linux/x86_64 -W .github/workflows/edenfs_linux.yml ``` X-link: facebook/sapling#1126 Differential Revision: D83007559 fbshipit-source-id: e44a3f8eed4cf032c3ad33b8dc306eb589901842
meta-codesync bot
pushed a commit
to facebookincubator/katran
that referenced
this pull request
Oct 13, 2025
Summary: Three independent changes: 1. Fix merge damage in FBPythonBinary.cmake 2. Define `fbcode_build=False` in rust builds to eliminate errors/warnings 3. Add a missing dependency to zstd Tested by building sapling using the GitHub action (won't run fully until other PRs land): ``` act --container-architecture linux/x86_64 -W .github/workflows/edenfs_linux.yml ``` X-link: facebook/sapling#1126 Differential Revision: D83007559 fbshipit-source-id: e44a3f8eed4cf032c3ad33b8dc306eb589901842
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three independent changes:
fbcode_build=Falsein rust builds to eliminate errors/warningsTested by building sapling using the GitHub action (won't run fully until other PRs land):