Skip to content

renderdag: emit link_line for same-column named parents#1293

Open
geraschenko wants to merge 1 commit intofacebook:mainfrom
geraschenko:anton/min_row_height_1
Open

renderdag: emit link_line for same-column named parents#1293
geraschenko wants to merge 1 commit intofacebook:mainfrom
geraschenko:anton/min_row_height_1

Conversation

@geraschenko
Copy link
Copy Markdown

Fixes #1292. With min_row_height(1), connected and disconnected same-column adjacent nodes render identically, with no between connected nodes.

Before / After (box_drawing, min_row_height=1) for new BASIC_DISCONNECTED fixture (dag: "A B-C", heads ["A", "C"]):

Before:
o  C
o  B
o  A

After:
o  C
│
o  B
o  A

With `min_row_height(1)`, connected and disconnected same-column adjacent nodes render identically, with no `│` between connected nodes. See facebook#1292.

Before / After (box_drawing, min_row_height=1) for new `BASIC_DISCONNECTED` fixture (`dag: "A B-C"`, heads `["A", "C"]`):
```
Before:
o  C
o  B
o  A

After:
o  C
│
o  B
o  A
```
@meta-cla
Copy link
Copy Markdown

meta-cla Bot commented Apr 26, 2026

Hi @geraschenko!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

@meta-cla
Copy link
Copy Markdown

meta-cla Bot commented Apr 26, 2026

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@meta-cla meta-cla Bot added the CLA Signed label Apr 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

renderdag: same-column connected nodes indistinguishable from disconnected ones with min_row_height=1

1 participant