Merge uniform hash changes into main#30
Merged
Merged
Conversation
…28) Add hash_fields() helper that hashes a domain separator followed by length-prefixed fields using I2OSP(len, 8) per RFC 8017. All three hash computations (commitment, SAS, session key) now use it, ensuring consistent, platform-independent encoding. This is a protocol-breaking change: commitment and SAS now length-prefix all fields (previously nonces were not prefixed).
meta-cla
Bot
added
the
CLA Signed
kevinlewi
approved these changes
May 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brings #28 (uniform
length-prefixed hashing) into main. It was accidentally merged into kdf-nits instead of main.