Skip to content

Add #[must_use] to all protocol entry points and output accessors#33

Open
AlfioEmanueleFresta wants to merge 1 commit into
facebook:mainfrom
AlfioEmanueleFresta:must-use
Open

Add #[must_use] to all protocol entry points and output accessors#33
AlfioEmanueleFresta wants to merge 1 commit into
facebook:mainfrom
AlfioEmanueleFresta:must-use

Conversation

@AlfioEmanueleFresta

Copy link
Copy Markdown

Summary

  • Adds #[must_use] to Initiator::start, Initiator::finish, Responder::start, Responder::finish, ProtocolOutput::sas_code, ProtocolOutput::into_session_key, and Sas::as_bytes.
  • Discarding any of these return values is almost certainly a bug; the compiler will now warn.

Summary

  • Adds #[must_use] to Initiator::start, Initiator::finish, Responder::start, Responder::finish, ProtocolOutput::sas_code, ProtocolOutput::into_session_key, and Sas::as_bytes.
  • Discarding any of these return values is almost certainly a bug. The compiler will now warn.

Test plan

  • Existing tests pass unchanged. No return values are discarded.

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Meta Open Source bot. label May 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Meta Open Source bot.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant