Skip to content

[eslint-plugin] Add inset shorthand expansion to stylex-valid-shorthands#1582

Closed
abhakat wants to merge 2 commits intomainfrom
inset-shorthand-autofix
Closed

[eslint-plugin] Add inset shorthand expansion to stylex-valid-shorthands#1582
abhakat wants to merge 2 commits intomainfrom
inset-shorthand-autofix

Conversation

@abhakat
Copy link
Copy Markdown
Contributor

@abhakat abhakat commented Apr 6, 2026

What changed / motivation ?

Expand inset, insetBlock, and insetInline shorthands into longhands.

  • inset: '0 10px'insetBlock: '0' + insetInline: '10px' (2-value logical)
  • inset: '0 10px 20px'top + right + bottom + left (3-4 value, physical per CSS spec)
  • insetBlock: '0 10px'insetBlockStart + insetBlockEnd
  • insetInline: '0 10px'insetInlineStart + insetInlineEnd
  • Single values pass through unchanged

Linked PR/Issues

Follow-up to #1553, #1552

Additional Context

Tests covering: single-value passthrough, 2/3/4-value expansion, preferInline option,
insetBlock/insetInline axis expansion.

Pre-flight checklist

@vercel
Copy link
Copy Markdown

vercel Bot commented Apr 6, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated (UTC)
stylex Skipped Skipped Apr 6, 2026 6:18pm

Request Review

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Apr 6, 2026
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 6, 2026

workflow: benchmarks/perf

Comparison of performance test results, measured in operations per second. Larger is better.
yarn workspace v1.22.22
yarn run v1.22.22
$ node ./compare.js /tmp/tmp.SM3xSSlGv0 /tmp/tmp.oT4G9unYYn

Results Base Patch Ratio
babel-plugin: stylex.create
· basic create 544 547 1.01 +
· complex create 67 67 1.00
babel-plugin: stylex.createTheme
· basic themes 445 446 1.00 +
· complex themes 34 34 1.00
Done in 0.08s.
Done in 0.32s.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 6, 2026

workflow: benchmarks/size

Comparison of minified (terser) and compressed (brotli) size results, measured in bytes. Smaller is better.
yarn workspace v1.22.22
yarn run v1.22.22
$ node ./compare.js /tmp/tmp.napevQmVA2 /tmp/tmp.ZbxjipBJfJ

Results Base Patch Ratio
@stylexjs/stylex/lib/cjs/stylex.js
· compressed 1,441 1,441 1.00
· minified 4,386 4,386 1.00
@stylexjs/stylex/lib/cjs/inject.js
· compressed 1,793 1,793 1.00
· minified 4,915 4,915 1.00
benchmarks/size/.build/bundle.js
· compressed 496,650 496,650 1.00
· minified 4,847,840 4,847,840 1.00
benchmarks/size/.build/stylex.css
· compressed 99,653 99,653 1.00
· minified 747,850 747,850 1.00
Done in 0.07s.
Done in 0.32s.

@abhakat abhakat closed this Apr 6, 2026
@abhakat abhakat deleted the inset-shorthand-autofix branch April 6, 2026 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant