Skip to content
This repository was archived by the owner on Jan 13, 2022. It is now read-only.

TTTableViewCell background color issue on iPad devices#689

Merged
diederich merged 2 commits into
developmentfrom
unknown repository
Jan 5, 2012
Merged

TTTableViewCell background color issue on iPad devices#689
diederich merged 2 commits into
developmentfrom
unknown repository

Conversation

@aporat
Copy link
Copy Markdown
Contributor

@aporat aporat commented Sep 23, 2011

iPad table cell backgrounds aren't completely white, they have a little dark gray color background. This is an issue, as the background colors in the default style sheet are set as white. this creates a ugly white overlay if you use TTTableView text cells.

This change just change the background to clearColor, which blends nicely into the background (on both iPad & iPhone)

@coredream
Copy link
Copy Markdown

I see this issue as well on the iPad, and this fixes it. But note TTThumbsViewController ends up with a black background by default since it also uses TTSTYLEVAR(backgroundColor).

@aporat
Copy link
Copy Markdown
Contributor Author

aporat commented Sep 23, 2011

Yeah, i had the same issue as well.

we can either solve it by creating new styles just for the tables, such as tableBackgroundColor, or by updating the existing code to make sure the text background layer are white. I rather go over the TTViewControllers updates to avoid adding new styles

comment?

@coredream
Copy link
Copy Markdown

I agree, the latter is a better solution instead of creating new styles.

@aporat
Copy link
Copy Markdown
Contributor Author

aporat commented Sep 26, 2011

the last commit fixes the issue with the background color in the photo controller, so it's okay to merge as far as I know..

@colinyoung
Copy link
Copy Markdown

just a bump, i'm seeing this on the iPhone 5.0 simulator and device as well. @aporat's fix worked perfectly to fix the problem.

@aporat
Copy link
Copy Markdown
Contributor Author

aporat commented Jan 5, 2012

@diederich can you merge? it is a simple and important iPad fix

@diederich
Copy link
Copy Markdown
Contributor

While this might have quite an performance impact, I agree the default should be clearColor.
Devs will find this issue during performance optimization anyways and can fix/change it then.

diederich added a commit that referenced this pull request Jan 5, 2012
TTTableViewCell background color issue on iPad devices
@diederich diederich merged commit 8f27f02 into facebookarchive:development Jan 5, 2012
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants