Skip to content

Add virtual to void timeoutExpired() function. #181

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
soyoo wants to merge 1 commit into from
Closed

Add virtual to void timeoutExpired() function. #181

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion wangle/acceptor/ManagedConnection.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ class ManagedConnection:
};

// HHWheelTimer::Callback API (left for subclasses to implement).
void timeoutExpired() noexcept override = 0;
virtual void timeoutExpired() noexcept = 0;

@yfeldblum yfeldblum Nov 5, 2020

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But this is an override:

https://github.com/facebook/folly/blob/v2020.11.02.00/folly/io/async/AsyncTimeout.h#L79-L82


/**
* Print a human-readable description of the connection.
Expand Down