Fix build with GCC 13 (add missing <cstdint> include)#1089
Closed
thesamesam wants to merge 1 commit into
Closed
Conversation
GCC 13 (as usual for new compiler releases) shuffles around some internal includes and so <cstdint> is no longer transitively included. Explicitly include <cstdint> for uint32_t. Signed-off-by: Sam James <sam@gentoo.org>
Contributor
|
@yfeldblum has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Contributor
|
@yfeldblum merged this pull request in 7220385. |
facebook-github-bot
pushed a commit
to facebook/hhvm
that referenced
this pull request
Jan 23, 2023
Summary: GCC 13 (as usual for new compiler releases) shuffles around some internal includes and so <cstdint> is no longer transitively included. Explicitly include <cstdint> for uint32_t. Signed-off-by: Sam James <sam@gentoo.org> X-link: facebook/watchman#1089 Reviewed By: genevievehelsel Differential Revision: D42670019 Pulled By: yfeldblum fbshipit-source-id: 9af4d6ee546e72fe0ab2f1d93894db46a2f4d099
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GCC 13 (as usual for new compiler releases) shuffles around some internal includes and so is no longer transitively included.
Explicitly include for uint32_t.
Signed-off-by: Sam James sam@gentoo.org