run prettier over docs#796
Closed
wez wants to merge 2 commits into
Closed
Conversation
The package.json defines `yarn ci` as a command to verify that the docs conform to the right style, but this was failing because there were some missing plugins referenced by the config that we don't need in the watchman project and that were overly pedantic (generating an error because of the use of single quotes in the index page: single quotes are perfectly legal and much more convenient than the escaped HTML entity). `yarn prettier` is another command defined by the package.json; it runs code formatting over the website js and md files. While I may not agree with its styling it is automatic. This commit applies `yarn prettier` to the markdown files and fixes up the linter config so that it doesn't flag anything as bad here.
That is undesirable as we are generating the docs anyway. https://v2.docusaurus.io/docs/deployment/ Test Plan: built and inspected locally. Deployed to the live site.
facebook-github-bot
left a comment
facebook-github-bot
left a comment
Contributor
There was a problem hiding this comment.
@wez has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The package.json defines
yarn cias a command to verify thatthe docs conform to the right style, but this was failing because
there were some missing plugins referenced by the config that we
don't need in the watchman project and that were overly pedantic
(generating an error because of the use of single quotes in the
index page: single quotes are perfectly legal and much more convenient
than the escaped HTML entity).
yarn prettieris another command defined by the package.json; itruns code formatting over the website js and md files. While I
may not agree with its styling it is automatic.
This commit applies
yarn prettierto the markdown files and fixesup the linter config so that it doesn't flag anything as bad here.