Expose HadOverflow property in JavaScript bindings#1930
Closed
J8118 wants to merge 4 commits into
Closed
Conversation
Add getComputedHadOverflow() method and include hadOverflow in the Layout type returned by getComputedLayout(). This exposes the existing C API function YGNodeLayoutGetHadOverflow() which was previously missing from the JS bindings. Closes facebook#1773
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
facebook-github-tools
Bot
added
the
Shared with Meta
|
@fabriziocucci has imported this pull request. If you are a Meta employee, you can view this in D100144528. |
|
@fabriziocucci merged this pull request in 02d8ec6. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The C API provides
YGNodeLayoutGetHadOverflow()to check whether a node's layout had overflow, but this was not exposed in the JavaScript bindings. This PR adds:getComputedHadOverflow(): boolean— standalone method onNodehadOverflow: booleanfield in theLayouttype returned bygetComputedLayout()The implementation follows the exact same pattern as existing layout getters (e.g.,
getComputedWidth,getComputedHeight) and boolean accessors (e.g.,hasNewLayout).Closes #1773
Test plan
YGHadOverflowTest.test.tswith 4 test cases ported from the C++ test suite (tests/YGHadOverflowTest.cpp):hadOverflowis truehadOverflowis falsegetComputedLayout()includeshadOverflowfield