Using appliedParams instead of "supplied" params in compressBegin()

[bimbashrestha]

EDIT:

This PR doesn't change compression behavior, it is necessary for enabling ldm with dictionaries because resetCCtx changes ldm params

[Cyan4973]

Using appliedParams instead of "supplied" params in compressBegin()

Is this what we want ?
Describe the difference, and why it's better.

[felixhandte]

On further consideration, this is not a bug. If ZSTD_resetCCtx_internal() modifies cparams, then this is a bug that needs to be fixed. But it doesn't, and shouldn't.

@Cyan4973, there is no difference. But I guess the point is that if there were, it would be important for us to use the applied params, not the requested params.

[bimbashrestha]

On further consideration, this is not a bug. If ZSTD_resetCCtx_internal() modifies cparams, then this is a bug that needs to be fixed. But it doesn't, and shouldn't.

It calls ZSTD_ldm_adjustParameters when we're in ldm mode though (which sets the ldm params). And I need to be able to use that inside loadDictionaryContent when filling the ldm hash tables.

[felixhandte]

Ok, sorry, yes. I was talking specifically about the cparams.

[terrelln]

While not a bug, it is necessary to fill LDM tables while loading the dictionary.