avoid potential RC on ctx->threadLimit (gh-4547), code review#4601
Merged
terrelln merged 1 commit intofacebook:devfrom Mar 2, 2026
Merged
avoid potential RC on ctx->threadLimit (gh-4547), code review#4601terrelln merged 1 commit intofacebook:devfrom
terrelln merged 1 commit intofacebook:devfrom
Conversation
terrelln
approved these changes
Mar 2, 2026
| return 0; | ||
| } | ||
| /* numThreads > threadCapacity */ | ||
| ctx->threadLimit = numThreads; |
Contributor
There was a problem hiding this comment.
This is a minor change in behavior when an operation fails below, but it seems fine & slightly preferable.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As already said in #4547, there is no RC currently, but for consistence reasons and to avoid potential RC in the future by possible changes...
Possible alternative could be to lock the fresh created mutex before first worker thread gets created (and unlock it before return).
Closes #4547, replaces #4558