Add ability to control level of legacy support, and drop support for versions v01-v03#600
Merged
Conversation
Cyan4973
reviewed
Mar 14, 2017
| #include "zstd_v06.h" | ||
| #include "zstd_v07.h" | ||
|
|
||
| #ifndef ZSTD_LEGACY_SUPPORT |
Contributor
There was a problem hiding this comment.
Another use case to properly support is if ZSTD_LEGACY_SUPPORT is defined with value 0.
This is up to now supported, and means "no legacy support".
But in proposed code, it seems it would mean the otherwise, supporting all legacy versions.
Contributor
Author
There was a problem hiding this comment.
Right, good point. In practice this wouldn't affect much, as all the locations that include zstd_legacy.h check if ZSTD_LEGACY_SUPPORT == 0 first, but I'll add a check here just to be sure.
Contributor
|
great patch ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.